chromeos/network/network_change_notifier_chromeos.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_change_notifier_chromeos.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/network_change_notifier_chromeos.cc

diff --git a/chromeos/network/network_change_notifier_chromeos.cc b/chromeos/network/network_change_notifier_chromeos.cc

index 52ee616a184938c032d185b6cbc694b5e43e2b66..4561091d5214e172a6f53d28e8fac3a998696d6b 100644

--- a/chromeos/network/network_change_notifier_chromeos.cc

+++ b/chromeos/network/network_change_notifier_chromeos.cc

@@ -211,8 +211,9 @@

NET_LOG_EVENT(

"NCNDefaultDNSServerChanged",

base::StringPrintf(

- "%s -> %s", base::JoinString(dns_servers_, ",").c_str(),

- base::JoinString(default_network->dns_servers(), ",").c_str()));

+ "%s -> %s",

+ JoinString(dns_servers_, ",").c_str(),

+ JoinString(default_network->dns_servers(), ",").c_str()));

*dns_changed = true;

}

« no previous file with comments | « chromecast/base/process_utils.cc ('k') | chromeos/network/onc/onc_validator.cc » ('j') | no next file with comments »