content/browser/speech/google_one_shot_remote_engine.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/google_one_shot_remote_engine.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/speech/google_one_shot_remote_engine.cc

diff --git a/content/browser/speech/google_one_shot_remote_engine.cc b/content/browser/speech/google_one_shot_remote_engine.cc

index 48afc800a4dc4cbea1f264d6694182c83b8d4238..92e4cb3beb316b441d3cf9adfb198f6b336c2fbd 100644

--- a/content/browser/speech/google_one_shot_remote_engine.cc

+++ b/content/browser/speech/google_one_shot_remote_engine.cc

@@ -205,8 +205,7 @@

std::string api_key = google_apis::GetAPIKey();

parts.push_back("key=" + net::EscapeQueryParamValue(api_key, true));

- GURL url(std::string(kDefaultSpeechRecognitionUrl) +

- base::JoinString(parts, "&"));

+ GURL url(std::string(kDefaultSpeechRecognitionUrl) + JoinString(parts, '&'));

encoder_.reset(AudioEncoder::Create(kDefaultAudioCodec,

config_.audio_sample_rate,