Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: content/browser/renderer_host/pepper/pepper_tcp_socket.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/pepper/pepper_tcp_socket.h" 5 #include "content/browser/renderer_host/pepper/pepper_tcp_socket.h"
6 6
7 #include <string.h> 7 #include <string.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_COMMON_NAME, 306 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_COMMON_NAME,
307 new base::StringValue(issuer.common_name)); 307 new base::StringValue(issuer.common_name));
308 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_LOCALITY_NAME, 308 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_LOCALITY_NAME,
309 new base::StringValue(issuer.locality_name)); 309 new base::StringValue(issuer.locality_name));
310 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_STATE_OR_PROVINCE_NAME, 310 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_STATE_OR_PROVINCE_NAME,
311 new base::StringValue(issuer.state_or_province_name)); 311 new base::StringValue(issuer.state_or_province_name));
312 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_COUNTRY_NAME, 312 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_COUNTRY_NAME,
313 new base::StringValue(issuer.country_name)); 313 new base::StringValue(issuer.country_name));
314 fields->SetField( 314 fields->SetField(
315 PP_X509CERTIFICATE_PRIVATE_ISSUER_ORGANIZATION_NAME, 315 PP_X509CERTIFICATE_PRIVATE_ISSUER_ORGANIZATION_NAME,
316 new base::StringValue(base::JoinString(issuer.organization_names, "\n"))); 316 new base::StringValue(JoinString(issuer.organization_names, '\n')));
317 fields->SetField( 317 fields->SetField(
318 PP_X509CERTIFICATE_PRIVATE_ISSUER_ORGANIZATION_UNIT_NAME, 318 PP_X509CERTIFICATE_PRIVATE_ISSUER_ORGANIZATION_UNIT_NAME,
319 new base::StringValue( 319 new base::StringValue(JoinString(issuer.organization_unit_names, '\n')));
320 base::JoinString(issuer.organization_unit_names, "\n")));
321 320
322 const net::CertPrincipal& subject = cert.subject(); 321 const net::CertPrincipal& subject = cert.subject();
323 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_COMMON_NAME, 322 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_COMMON_NAME,
324 new base::StringValue(subject.common_name)); 323 new base::StringValue(subject.common_name));
325 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_LOCALITY_NAME, 324 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_LOCALITY_NAME,
326 new base::StringValue(subject.locality_name)); 325 new base::StringValue(subject.locality_name));
327 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_STATE_OR_PROVINCE_NAME, 326 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_STATE_OR_PROVINCE_NAME,
328 new base::StringValue(subject.state_or_province_name)); 327 new base::StringValue(subject.state_or_province_name));
329 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_COUNTRY_NAME, 328 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_COUNTRY_NAME,
330 new base::StringValue(subject.country_name)); 329 new base::StringValue(subject.country_name));
331 fields->SetField( 330 fields->SetField(
332 PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_NAME, 331 PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_NAME,
333 new base::StringValue( 332 new base::StringValue(JoinString(subject.organization_names, '\n')));
334 base::JoinString(subject.organization_names, "\n")));
335 fields->SetField( 333 fields->SetField(
336 PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_UNIT_NAME, 334 PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_UNIT_NAME,
337 new base::StringValue( 335 new base::StringValue(JoinString(subject.organization_unit_names, '\n')));
338 base::JoinString(subject.organization_unit_names, "\n")));
339 336
340 const std::string& serial_number = cert.serial_number(); 337 const std::string& serial_number = cert.serial_number();
341 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SERIAL_NUMBER, 338 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SERIAL_NUMBER,
342 base::BinaryValue::CreateWithCopiedBuffer( 339 base::BinaryValue::CreateWithCopiedBuffer(
343 serial_number.data(), serial_number.length())); 340 serial_number.data(), serial_number.length()));
344 fields->SetField(PP_X509CERTIFICATE_PRIVATE_VALIDITY_NOT_BEFORE, 341 fields->SetField(PP_X509CERTIFICATE_PRIVATE_VALIDITY_NOT_BEFORE,
345 new base::FundamentalValue(cert.valid_start().ToDoubleT())); 342 new base::FundamentalValue(cert.valid_start().ToDoubleT()));
346 fields->SetField(PP_X509CERTIFICATE_PRIVATE_VALIDITY_NOT_AFTER, 343 fields->SetField(PP_X509CERTIFICATE_PRIVATE_VALIDITY_NOT_AFTER,
347 new base::FundamentalValue(cert.valid_expiry().ToDoubleT())); 344 new base::FundamentalValue(cert.valid_expiry().ToDoubleT()));
348 std::string der; 345 std::string der;
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
534 531
535 int net_result = socket_->Write( 532 int net_result = socket_->Write(
536 write_buffer_.get(), 533 write_buffer_.get(),
537 write_buffer_->BytesRemaining(), 534 write_buffer_->BytesRemaining(),
538 base::Bind(&PepperTCPSocket::OnWriteCompleted, base::Unretained(this))); 535 base::Bind(&PepperTCPSocket::OnWriteCompleted, base::Unretained(this)));
539 if (net_result != net::ERR_IO_PENDING) 536 if (net_result != net::ERR_IO_PENDING)
540 OnWriteCompleted(net_result); 537 OnWriteCompleted(net_result);
541 } 538 }
542 539
543 } // namespace content 540 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/renderer_host/pepper/pepper_socket_utils.cc ('k') | content/browser/renderer_host/websocket_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698