extensions/common/features/base_feature_provider.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/base_feature_provider.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/features/base_feature_provider.cc

diff --git a/extensions/common/features/base_feature_provider.cc b/extensions/common/features/base_feature_provider.cc

index 472e1f55122b89a44fb7aa0973e7c6982560aa13..9d24d84ad085bc7d7badd9f3a3b1ce920c69e16c 100644

--- a/extensions/common/features/base_feature_provider.cc

+++ b/extensions/common/features/base_feature_provider.cc

@@ -62,7 +62,7 @@

std::stack<std::pair<std::string, const base::DictionaryValue*> >

parse_stack;

while (!split.empty()) {

- std::string parent_name = base::JoinString(split, ".");

+ std::string parent_name = JoinString(split, '.');

split.pop_back();

if (root.HasKey(parent_name)) {

const base::DictionaryValue* parent = nullptr;

@@ -176,7 +176,7 @@

if (split.size() < 2)

return nullptr;

split.pop_back();

- return GetFeature(base::JoinString(split, "."));

+ return GetFeature(JoinString(split, '.'));

}

// Children of a given API are named starting with parent.name()+".", which