chrome/test/chromedriver/chrome_launcher.cc - Issue 1237873004: Revert of Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 1237873004: Revert of Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome_launcher.cc

diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc

index 9c35f8f6e35d69b11d53f5ed998ac663c8dcdb0a..5a79d678006ab640e204ff690606710cd0fe2ef7 100644

--- a/chrome/test/chromedriver/chrome_launcher.cc

+++ b/chrome/test/chromedriver/chrome_launcher.cc

@@ -749,8 +749,8 @@

}

if (extension_paths.size()) {

- base::FilePath::StringType extension_paths_value = base::JoinString(

- extension_paths, base::FilePath::StringType(1, ','));

+ base::FilePath::StringType extension_paths_value = JoinString(

+ extension_paths, FILE_PATH_LITERAL(','));

UpdateExtensionSwitch(switches, "load-extension", extension_paths_value);

}

bg_pages->swap(bg_pages_tmp);