|
Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.
It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is
generally undefined on Mac, but as of r223369, it is incorrect in Chrome on
Mac.
To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not
used with close, and that IGNORE_EINTR is only used with close. Unnecessary
#includes of eintr_wrapper.h are also removed.
base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc
contain non-mechanical changes. Variable naming within the latter is updated
per r178174. Missing #includes for <errno.h> in
content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were
manually added. Mechanical changes were generated by running:
sed -E -i '' \
-e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \
-e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \
-e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \
$(git grep -El 'HANDLE_EINTR.*close')
sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \
$(grep -EL '(HANDLE|IGNORE)_EINTR' \
$(git grep -El '#include.*eintr_wrapper\.h"'))
BUG= 269623
R=agl@chromium.org, jln@chromium.org
TBR=OWNERS
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238390
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+234 lines, -189 lines) |
Patch |
![](/static/closedtriangle.gif) |
M |
PRESUBMIT.py
|
View
|
1
2
3
|
2 chunks |
+32 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/debug/debugger_posix.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/file_util.h
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/file_util_posix.cc
|
View
|
1
2
3
|
7 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/files/dir_reader_linux.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/files/file_path_watcher_kqueue.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/files/file_posix.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/files/memory_mapped_file_posix.cc
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/memory/discardable_memory_android.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/message_loop/message_loop_unittest.cc
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/message_loop/message_pump_io_ios_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/message_loop/message_pump_libevent.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/message_loop/message_pump_libevent_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/platform_file_posix.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/posix/eintr_wrapper.h
|
View
|
|
3 chunks |
+16 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/posix/file_descriptor_shuffle.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/posix/unix_domain_socket_linux_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/process/launch_posix.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/process/process_util_unittest.cc
|
View
|
|
5 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
base/test/multiprocess_test_android.cc
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/extensions/api/serial/serial_connection_posix.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/process_info_snapshot_mac_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/process_singleton_linux.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/process_singleton_mac.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/browser/shell_integration_linux.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/common/multi_process_lock_linux.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/common/service_process_util_posix.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chromeos/dbus/debug_daemon_client.cc
|
View
|
1
2
3
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chromeos/process_proxy/process_output_watcher.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chromeos/process_proxy/process_output_watcher_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chromeos/process_proxy/process_proxy.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chromeos/process_proxy/process_proxy_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
components/breakpad/browser/crash_handler_host_linux.cc
|
View
|
|
5 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
components/nacl/browser/nacl_process_host.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
components/nacl/loader/nacl_helper_linux.cc
|
View
|
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
components/nacl/zygote/nacl_fork_delegate_linux.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/browser/renderer_host/render_sandbox_host_linux.cc
|
View
|
|
4 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/browser/renderer_host/render_widget_helper.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/common/font_config_ipc_linux.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/common/gpu/media/exynos_video_decode_accelerator.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/common/gpu/media/exynos_video_encode_accelerator.cc
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/common/plugin_list_posix.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/common/sandbox_linux.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/plugin/plugin_channel.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/zygote/zygote_main_linux.cc
|
View
|
1
2
|
3 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
device/bluetooth/bluetooth_socket_chromeos.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
ipc/file_descriptor_set_posix.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
ipc/file_descriptor_set_posix_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
ipc/ipc_channel_factory.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
ipc/ipc_channel_posix.cc
|
View
|
|
8 chunks |
+11 lines, -11 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
ipc/ipc_channel_posix_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
ipc/ipc_send_fds_test.cc
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/base/user_input_monitor_linux.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
net/base/address_tracker_linux.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
net/base/net_util_posix.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
net/dns/address_sorter_posix.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
net/socket/tcp_listen_socket_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
net/socket/tcp_socket_libevent.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
net/socket/unix_domain_socket_posix.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
net/socket/unix_domain_socket_posix_unittest.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
net/udp/udp_socket_libevent.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
net/udp/udp_socket_win.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
ppapi/proxy/plugin_dispatcher.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
ppapi/tests/test_broker.cc
|
View
|
|
3 chunks |
+19 lines, -6 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
printing/pdf_metafile_skia.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
remoting/host/ipc_util_posix.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
remoting/host/local_input_monitor_linux.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
rlz/lib/recursive_cross_process_lock_posix.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
sandbox/linux/seccomp-bpf/sandbox_bpf.cc
|
View
|
|
6 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
sandbox/linux/seccomp-bpf/syscall_unittest.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
sandbox/linux/seccomp-bpf/trap.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
sandbox/linux/services/broker_process.cc
|
View
|
|
5 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
sandbox/linux/services/broker_process_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
sandbox/linux/services/init_process_reaper.cc
|
View
|
|
4 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
sandbox/linux/tests/unit_tests.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
third_party/leveldatabase/env_chromium.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
tools/android/common/adb_connection.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
tools/android/common/daemon.cc
|
View
|
1
2
|
3 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
tools/android/forwarder/forwarder.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
tools/android/forwarder2/common.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
tools/android/forwarder2/host_forwarder_main.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
tools/android/forwarder2/pipe_notifier.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
ui/surface/transport_dib_posix.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
Total messages: 9 (0 generated)
|