Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2223)

Unified Diff: base/test/multiprocess_test_android.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/test/multiprocess_test_android.cc
diff --git a/base/test/multiprocess_test_android.cc b/base/test/multiprocess_test_android.cc
index 93674269eb1822857d38b14fa26882248a8cc540..51c2ce020d09e50e3352a8609d74462f1c4969fd 100644
--- a/base/test/multiprocess_test_android.cc
+++ b/base/test/multiprocess_test_android.cc
@@ -8,7 +8,6 @@
#include "base/containers/hash_tables.h"
#include "base/logging.h"
-#include "base/posix/eintr_wrapper.h"
#include "testing/multiprocess_func_list.h"
namespace base {
@@ -42,7 +41,7 @@ ProcessHandle MultiProcessTest::SpawnChildImpl(
const int kFdForAndroidLogging = 3; // FD used by __android_log_write().
for (int fd = kFdForAndroidLogging + 1; fd < getdtablesize(); ++fd) {
if (fds_to_keep_open.find(fd) == fds_to_keep_open.end()) {
- HANDLE_EINTR(close(fd));
+ close(fd);
}
}
for (FileHandleMappingVector::const_iterator it = fds_to_remap.begin();
@@ -52,7 +51,7 @@ ProcessHandle MultiProcessTest::SpawnChildImpl(
if (dup2(old_fd, new_fd) < 0) {
PLOG(FATAL) << "dup2";
}
- HANDLE_EINTR(close(old_fd));
+ close(old_fd);
}
_exit(multi_process_function_list::InvokeChildProcessTest(procname));
return 0;
« no previous file with comments | « base/process/process_util_unittest.cc ('k') | chrome/browser/extensions/api/serial/serial_connection_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698