printing/pdf_metafile_skia.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/pdf_metafile_skia.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: printing/pdf_metafile_skia.cc

diff --git a/printing/pdf_metafile_skia.cc b/printing/pdf_metafile_skia.cc

index 2242cfc0175781e17b9dfd0393cdf535de38ca94..57e635ab5bf56caa692f3519c212e4888894bffb 100644

--- a/printing/pdf_metafile_skia.cc

+++ b/printing/pdf_metafile_skia.cc

@@ -212,7 +212,7 @@ bool PdfMetafileSkia::SaveToFD(const base::FileDescriptor& fd) const {

}

if (fd.auto_close) {

- if (HANDLE_EINTR(close(fd.fd)) < 0) {

+ if (IGNORE_EINTR(close(fd.fd)) < 0) {

DPLOG(WARNING) << "close";

result = false;

}

« no previous file with comments | « ppapi/tests/test_broker.cc ('k') | remoting/host/ipc_util_posix.cc » ('j') | no next file with comments »