net/socket/tcp_listen_socket_unittest.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/tcp_listen_socket_unittest.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/tcp_listen_socket_unittest.cc

diff --git a/net/socket/tcp_listen_socket_unittest.cc b/net/socket/tcp_listen_socket_unittest.cc

index 2410677c0bd519599e81c156e1b4bc8f2971ba31..41c41f81fe7f6c1d116bf29f1b1204eb15960065 100644

--- a/net/socket/tcp_listen_socket_unittest.cc

+++ b/net/socket/tcp_listen_socket_unittest.cc

@@ -73,7 +73,7 @@ void TCPListenSocketTester::TearDown() {

#if defined(OS_WIN)

ASSERT_EQ(0, closesocket(test_socket_));

#elif defined(OS_POSIX)

- ASSERT_EQ(0, HANDLE_EINTR(close(test_socket_)));

+ ASSERT_EQ(0, IGNORE_EINTR(close(test_socket_)));

#endif

NextAction();

ASSERT_EQ(ACTION_CLOSE, last_action_.type());

« no previous file with comments | « net/dns/address_sorter_posix.cc ('k') | net/socket/tcp_socket_libevent.cc » ('j') | no next file with comments »