ipc/file_descriptor_set_posix_unittest.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/file_descriptor_set_posix_unittest.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/file_descriptor_set_posix_unittest.cc

diff --git a/ipc/file_descriptor_set_posix_unittest.cc b/ipc/file_descriptor_set_posix_unittest.cc

index b4a01414a551513bb06b3e4bdaf85cc8b83622e0..d9107f9f881ce67324b53fbd6653a5a9437abb94 100644

--- a/ipc/file_descriptor_set_posix_unittest.cc

+++ b/ipc/file_descriptor_set_posix_unittest.cc

@@ -24,8 +24,8 @@ int GetSafeFd() {

bool VerifyClosed(int fd) {

const int duped = dup(fd);

if (duped != -1) {

- EXPECT_NE(HANDLE_EINTR(close(duped)), -1);

- EXPECT_NE(HANDLE_EINTR(close(fd)), -1);

+ EXPECT_NE(IGNORE_EINTR(close(duped)), -1);

+ EXPECT_NE(IGNORE_EINTR(close(fd)), -1);

return false;

}

return true;

« no previous file with comments | « ipc/file_descriptor_set_posix.cc ('k') | ipc/ipc_channel_factory.cc » ('j') | no next file with comments »