components/nacl/browser/nacl_process_host.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/browser/nacl_process_host.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/browser/nacl_process_host.cc

diff --git a/components/nacl/browser/nacl_process_host.cc b/components/nacl/browser/nacl_process_host.cc

index aa79f4f75f125ee550c3d429f965f0c96c7d3070..e44df8983c3ffb3b10462746e3eca25fc0ed93d9 100644

--- a/components/nacl/browser/nacl_process_host.cc

+++ b/components/nacl/browser/nacl_process_host.cc

@@ -686,7 +686,7 @@ net::SocketDescriptor NaClProcessHost::GetDebugStubSocketHandle() {

}

if (listen(s, 1)) {

LOG(ERROR) << "listen() failed on debug stub socket";

- if (HANDLE_EINTR(close(s)) < 0)

+ if (IGNORE_EINTR(close(s)) < 0)

PLOG(ERROR) << "failed to close debug stub socket";

return net::kInvalidSocket;

}