ipc/ipc_channel_factory.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_factory.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_channel_factory.cc

diff --git a/ipc/ipc_channel_factory.cc b/ipc/ipc_channel_factory.cc

index f3ad11a6b4f35540b3d4cc6de8b278d99b3d97f3..5c24284f95dd3e64010cacbd9774e0d2707aa131 100644

--- a/ipc/ipc_channel_factory.cc

+++ b/ipc/ipc_channel_factory.cc

@@ -76,7 +76,7 @@ void ChannelFactory::OnFileCanWriteWithoutBlocking(int fd) {

void ChannelFactory::Close() {

if (listen_fd_ < 0)

return;

- if (HANDLE_EINTR(close(listen_fd_)) < 0)

+ if (IGNORE_EINTR(close(listen_fd_)) < 0)

PLOG(ERROR) << "close";

listen_fd_ = -1;

if (unlink(path_.value().c_str()) < 0)

« no previous file with comments | « ipc/file_descriptor_set_posix_unittest.cc ('k') | ipc/ipc_channel_posix.cc » ('j') | no next file with comments »