base/debug/debugger_posix.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/debugger_posix.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/debugger_posix.cc

diff --git a/base/debug/debugger_posix.cc b/base/debug/debugger_posix.cc

index cab4c4868d1b6efaeeda37429ac470661dcbbfb3..60ad521830844a650cd27ebc587d24a5e4466d9c 100644

--- a/base/debug/debugger_posix.cc

+++ b/base/debug/debugger_posix.cc

@@ -157,7 +157,7 @@ bool BeingDebugged() {

char buf[1024];

ssize_t num_read = HANDLE_EINTR(read(status_fd, buf, sizeof(buf)));

- if (HANDLE_EINTR(close(status_fd)) < 0)

+ if (IGNORE_EINTR(close(status_fd)) < 0)

return false;

if (num_read <= 0)

« no previous file with comments | « PRESUBMIT.py ('k') | base/file_util.h » ('j') | no next file with comments »