net/socket/unix_domain_socket_posix_unittest.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/unix_domain_socket_posix_unittest.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/unix_domain_socket_posix_unittest.cc

diff --git a/net/socket/unix_domain_socket_posix_unittest.cc b/net/socket/unix_domain_socket_posix_unittest.cc

index 652098583ca492fe874f61968085007543d1c18d..b1857e62e0e19df8f1d226def89fc954d4f8f951 100644

--- a/net/socket/unix_domain_socket_posix_unittest.cc

+++ b/net/socket/unix_domain_socket_posix_unittest.cc

@@ -306,7 +306,7 @@ TEST_F(UnixDomainSocketTest, TestWithClient) {

ASSERT_EQ(kMsg, socket_delegate_->ReceivedData());

// Close the client socket.

- ret = HANDLE_EINTR(close(sock));

+ ret = IGNORE_EINTR(close(sock));

event = event_manager_->WaitForEvent();

ASSERT_EQ(EVENT_CLOSE, event);

}

« no previous file with comments | « net/socket/unix_domain_socket_posix.cc ('k') | net/udp/udp_socket_libevent.cc » ('j') | no next file with comments »