Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: chromeos/dbus/debug_daemon_client.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/service_process_util_posix.cc ('k') | chromeos/process_proxy/process_output_watcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/debug_daemon_client.cc
diff --git a/chromeos/dbus/debug_daemon_client.cc b/chromeos/dbus/debug_daemon_client.cc
index 8c11a97a36d3dcd9d0ddc87d88a395e8263569e0..9d06e5f721003de08cbca3428d8f33965f30a0a8 100644
--- a/chromeos/dbus/debug_daemon_client.cc
+++ b/chromeos/dbus/debug_daemon_client.cc
@@ -56,7 +56,7 @@ class PipeReader {
virtual ~PipeReader() {
// Don't close pipe_fd_[0] as it's closed by data_stream_.
if (pipe_fd_[1] != -1)
- if (HANDLE_EINTR(close(pipe_fd_[1])) < 0)
+ if (IGNORE_EINTR(close(pipe_fd_[1])) < 0)
PLOG(ERROR) << "close[1]";
}
@@ -66,7 +66,7 @@ class PipeReader {
// Closes writeable descriptor; normally used in parent process after fork.
void CloseWriteFD() {
if (pipe_fd_[1] != -1) {
- if (HANDLE_EINTR(close(pipe_fd_[1])) < 0)
+ if (IGNORE_EINTR(close(pipe_fd_[1])) < 0)
PLOG(ERROR) << "close";
pipe_fd_[1] = -1;
}
« no previous file with comments | « chrome/common/service_process_util_posix.cc ('k') | chromeos/process_proxy/process_output_watcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698