base/posix/file_descriptor_shuffle.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/posix/file_descriptor_shuffle.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/posix/file_descriptor_shuffle.cc

diff --git a/base/posix/file_descriptor_shuffle.cc b/base/posix/file_descriptor_shuffle.cc

index b5b7339bdfa34a6b78119cab52acf896bf6631b5..7bc9e26eb5825879fe5aa2eddd3ec991c91a0dd2 100644

--- a/base/posix/file_descriptor_shuffle.cc

+++ b/base/posix/file_descriptor_shuffle.cc

@@ -89,7 +89,7 @@ bool FileDescriptorTableInjection::Move(int src, int dest) {

}

void FileDescriptorTableInjection::Close(int fd) {

- int ret = HANDLE_EINTR(close(fd));

+ int ret = IGNORE_EINTR(close(fd));

DPCHECK(ret == 0);

}

« no previous file with comments | « base/posix/eintr_wrapper.h ('k') | base/posix/unix_domain_socket_linux_unittest.cc » ('j') | no next file with comments »