Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: base/posix/file_descriptor_shuffle.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/posix/eintr_wrapper.h ('k') | base/posix/unix_domain_socket_linux_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/posix/file_descriptor_shuffle.h" 5 #include "base/posix/file_descriptor_shuffle.h"
6 6
7 #include <unistd.h> 7 #include <unistd.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <ostream> 9 #include <ostream>
10 10
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 bool FileDescriptorTableInjection::Duplicate(int* result, int fd) { 82 bool FileDescriptorTableInjection::Duplicate(int* result, int fd) {
83 *result = HANDLE_EINTR(dup(fd)); 83 *result = HANDLE_EINTR(dup(fd));
84 return *result >= 0; 84 return *result >= 0;
85 } 85 }
86 86
87 bool FileDescriptorTableInjection::Move(int src, int dest) { 87 bool FileDescriptorTableInjection::Move(int src, int dest) {
88 return HANDLE_EINTR(dup2(src, dest)) != -1; 88 return HANDLE_EINTR(dup2(src, dest)) != -1;
89 } 89 }
90 90
91 void FileDescriptorTableInjection::Close(int fd) { 91 void FileDescriptorTableInjection::Close(int fd) {
92 int ret = HANDLE_EINTR(close(fd)); 92 int ret = IGNORE_EINTR(close(fd));
93 DPCHECK(ret == 0); 93 DPCHECK(ret == 0);
94 } 94 }
95 95
96 } // namespace base 96 } // namespace base
OLDNEW
« no previous file with comments | « base/posix/eintr_wrapper.h ('k') | base/posix/unix_domain_socket_linux_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698