tools/android/forwarder/forwarder.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/forwarder/forwarder.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/android/forwarder/forwarder.cc

diff --git a/tools/android/forwarder/forwarder.cc b/tools/android/forwarder/forwarder.cc

index e77c8065ff65262c9a5ffdc6cace7695c3e03e07..fe499033e55ccf5bd2a831264171f9faa608d670 100644

--- a/tools/android/forwarder/forwarder.cc

+++ b/tools/android/forwarder/forwarder.cc

@@ -31,7 +31,7 @@ volatile bool g_killed = false;

void CloseSocket(int fd) {

if (fd >= 0) {

int old_errno = errno;

- (void) HANDLE_EINTR(close(fd));

+ close(fd);

errno = old_errno;

}

« no previous file with comments | « tools/android/common/daemon.cc ('k') | tools/android/forwarder2/common.cc » ('j') | no next file with comments »