base/message_loop/message_pump_libevent.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/message_loop/message_pump_libevent.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/message_loop/message_pump_libevent.cc

diff --git a/base/message_loop/message_pump_libevent.cc b/base/message_loop/message_pump_libevent.cc

index 6d862d1d2662e269c5081a61149eb4c4f718736f..26be687c6dd1162788415e540c2e83883bc206a9 100644

--- a/base/message_loop/message_pump_libevent.cc

+++ b/base/message_loop/message_pump_libevent.cc

@@ -125,11 +125,11 @@ MessagePumpLibevent::~MessagePumpLibevent() {

event_del(wakeup_event_);

delete wakeup_event_;

if (wakeup_pipe_in_ >= 0) {

- if (HANDLE_EINTR(close(wakeup_pipe_in_)) < 0)

+ if (IGNORE_EINTR(close(wakeup_pipe_in_)) < 0)

DPLOG(ERROR) << "close";

}

if (wakeup_pipe_out_ >= 0) {

- if (HANDLE_EINTR(close(wakeup_pipe_out_)) < 0)

+ if (IGNORE_EINTR(close(wakeup_pipe_out_)) < 0)

DPLOG(ERROR) << "close";

}

event_base_free(event_base_);