base/platform_file_posix.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/platform_file_posix.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/platform_file_posix.cc

diff --git a/base/platform_file_posix.cc b/base/platform_file_posix.cc

index 2bd9cd0b08ff4dbab95676166a6c3e18f5680f04..028a38276d6fedd3954ff4f2a9df68086418021e 100644

--- a/base/platform_file_posix.cc

+++ b/base/platform_file_posix.cc

@@ -221,7 +221,7 @@ FILE* FdopenPlatformFile(PlatformFile file, const char* mode) {

bool ClosePlatformFile(PlatformFile file) {

base::ThreadRestrictions::AssertIOAllowed();

- return !HANDLE_EINTR(close(file));

+ return !IGNORE_EINTR(close(file));

}

int64 SeekPlatformFile(PlatformFile file,

« no previous file with comments | « base/message_loop/message_pump_libevent_unittest.cc ('k') | base/posix/eintr_wrapper.h » ('j') | no next file with comments »