Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Side by Side Diff: sandbox/linux/services/init_process_reaper.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sandbox/linux/services/broker_process_unittest.cc ('k') | sandbox/linux/tests/unit_tests.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sandbox/linux/services/init_process_reaper.h" 5 #include "sandbox/linux/services/init_process_reaper.h"
6 6
7 #include <signal.h> 7 #include <signal.h>
8 #include <string.h> 8 #include <string.h>
9 #include <sys/socket.h> 9 #include <sys/socket.h>
10 #include <sys/types.h> 10 #include <sys/types.h>
(...skipping 15 matching lines...) Expand all
26 bool CreateInitProcessReaper(base::Closure* post_fork_parent_callback) { 26 bool CreateInitProcessReaper(base::Closure* post_fork_parent_callback) {
27 int sync_fds[2]; 27 int sync_fds[2];
28 // We want to use send, so we can't use a pipe 28 // We want to use send, so we can't use a pipe
29 if (socketpair(AF_UNIX, SOCK_STREAM, 0, sync_fds)) { 29 if (socketpair(AF_UNIX, SOCK_STREAM, 0, sync_fds)) {
30 PLOG(ERROR) << "Failed to create socketpair"; 30 PLOG(ERROR) << "Failed to create socketpair";
31 return false; 31 return false;
32 } 32 }
33 pid_t child_pid = fork(); 33 pid_t child_pid = fork();
34 if (child_pid == -1) { 34 if (child_pid == -1) {
35 int close_ret; 35 int close_ret;
36 close_ret = HANDLE_EINTR(close(sync_fds[0])); 36 close_ret = IGNORE_EINTR(close(sync_fds[0]));
37 DPCHECK(!close_ret); 37 DPCHECK(!close_ret);
38 close_ret = HANDLE_EINTR(close(sync_fds[1])); 38 close_ret = IGNORE_EINTR(close(sync_fds[1]));
39 DPCHECK(!close_ret); 39 DPCHECK(!close_ret);
40 return false; 40 return false;
41 } 41 }
42 if (child_pid) { 42 if (child_pid) {
43 // In the parent, assuming the role of an init process. 43 // In the parent, assuming the role of an init process.
44 // The disposition for SIGCHLD cannot be SIG_IGN or wait() will only return 44 // The disposition for SIGCHLD cannot be SIG_IGN or wait() will only return
45 // once all of our childs are dead. Since we're init we need to reap childs 45 // once all of our childs are dead. Since we're init we need to reap childs
46 // as they come. 46 // as they come.
47 struct sigaction action; 47 struct sigaction action;
48 memset(&action, 0, sizeof(action)); 48 memset(&action, 0, sizeof(action));
49 action.sa_handler = &DoNothingSignalHandler; 49 action.sa_handler = &DoNothingSignalHandler;
50 CHECK(sigaction(SIGCHLD, &action, NULL) == 0); 50 CHECK(sigaction(SIGCHLD, &action, NULL) == 0);
51 51
52 int close_ret; 52 int close_ret;
53 close_ret = HANDLE_EINTR(close(sync_fds[0])); 53 close_ret = IGNORE_EINTR(close(sync_fds[0]));
54 DPCHECK(!close_ret); 54 DPCHECK(!close_ret);
55 close_ret = shutdown(sync_fds[1], SHUT_RD); 55 close_ret = shutdown(sync_fds[1], SHUT_RD);
56 DPCHECK(!close_ret); 56 DPCHECK(!close_ret);
57 if (post_fork_parent_callback) 57 if (post_fork_parent_callback)
58 post_fork_parent_callback->Run(); 58 post_fork_parent_callback->Run();
59 // Tell the child to continue 59 // Tell the child to continue
60 CHECK(HANDLE_EINTR(send(sync_fds[1], "C", 1, MSG_NOSIGNAL)) == 1); 60 CHECK(HANDLE_EINTR(send(sync_fds[1], "C", 1, MSG_NOSIGNAL)) == 1);
61 close_ret = HANDLE_EINTR(close(sync_fds[1])); 61 close_ret = IGNORE_EINTR(close(sync_fds[1]));
62 DPCHECK(!close_ret); 62 DPCHECK(!close_ret);
63 63
64 for (;;) { 64 for (;;) {
65 // Loop until we have reaped our one natural child 65 // Loop until we have reaped our one natural child
66 siginfo_t reaped_child_info; 66 siginfo_t reaped_child_info;
67 int wait_ret = 67 int wait_ret =
68 HANDLE_EINTR(waitid(P_ALL, 0, &reaped_child_info, WEXITED)); 68 HANDLE_EINTR(waitid(P_ALL, 0, &reaped_child_info, WEXITED));
69 if (wait_ret) 69 if (wait_ret)
70 _exit(1); 70 _exit(1);
71 if (reaped_child_info.si_pid == child_pid) { 71 if (reaped_child_info.si_pid == child_pid) {
72 int exit_code = 0; 72 int exit_code = 0;
73 // We're done waiting 73 // We're done waiting
74 if (reaped_child_info.si_code == CLD_EXITED) { 74 if (reaped_child_info.si_code == CLD_EXITED) {
75 exit_code = reaped_child_info.si_status; 75 exit_code = reaped_child_info.si_status;
76 } 76 }
77 // Exit with the same exit code as our parent. Exit with 0 if we got 77 // Exit with the same exit code as our parent. Exit with 0 if we got
78 // signaled. 78 // signaled.
79 _exit(exit_code); 79 _exit(exit_code);
80 } 80 }
81 } 81 }
82 } else { 82 } else {
83 // The child needs to wait for the parent to run the callback to avoid a 83 // The child needs to wait for the parent to run the callback to avoid a
84 // race condition. 84 // race condition.
85 int close_ret; 85 int close_ret;
86 close_ret = HANDLE_EINTR(close(sync_fds[1])); 86 close_ret = IGNORE_EINTR(close(sync_fds[1]));
87 DPCHECK(!close_ret); 87 DPCHECK(!close_ret);
88 close_ret = shutdown(sync_fds[0], SHUT_WR); 88 close_ret = shutdown(sync_fds[0], SHUT_WR);
89 DPCHECK(!close_ret); 89 DPCHECK(!close_ret);
90 char should_continue; 90 char should_continue;
91 int read_ret = HANDLE_EINTR(read(sync_fds[0], &should_continue, 1)); 91 int read_ret = HANDLE_EINTR(read(sync_fds[0], &should_continue, 1));
92 close_ret = HANDLE_EINTR(close(sync_fds[0])); 92 close_ret = IGNORE_EINTR(close(sync_fds[0]));
93 DPCHECK(!close_ret); 93 DPCHECK(!close_ret);
94 if (read_ret == 1) 94 if (read_ret == 1)
95 return true; 95 return true;
96 else 96 else
97 return false; 97 return false;
98 } 98 }
99 } 99 }
100 100
101 } // namespace sandbox. 101 } // namespace sandbox.
OLDNEW
« no previous file with comments | « sandbox/linux/services/broker_process_unittest.cc ('k') | sandbox/linux/tests/unit_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698