Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: base/posix/eintr_wrapper.h

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/platform_file_posix.cc ('k') | base/posix/file_descriptor_shuffle.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This provides a wrapper around system calls which may be interrupted by a 5 // This provides a wrapper around system calls which may be interrupted by a
6 // signal and return EINTR. See man 7 signal. 6 // signal and return EINTR. See man 7 signal.
7 // To prevent long-lasting loops (which would likely be a bug, such as a signal 7 // To prevent long-lasting loops (which would likely be a bug, such as a signal
8 // that should be masked) to go unnoticed, there is a limit after which the 8 // that should be masked) to go unnoticed, there is a limit after which the
9 // caller will nonetheless see an EINTR in Debug builds. 9 // caller will nonetheless see an EINTR in Debug builds.
10 // 10 //
11 // On Windows, this wrapper macro does nothing. 11 // On Windows, this wrapper macro does nothing.
12 //
13 // Don't wrap close calls in HANDLE_EINTR. Use IGNORE_EINTR if the return
14 // value of close is significant. See http://crbug.com/269623.
12 15
13 #ifndef BASE_POSIX_EINTR_WRAPPER_H_ 16 #ifndef BASE_POSIX_EINTR_WRAPPER_H_
14 #define BASE_POSIX_EINTR_WRAPPER_H_ 17 #define BASE_POSIX_EINTR_WRAPPER_H_
15 18
16 #include "build/build_config.h" 19 #include "build/build_config.h"
17 20
18 #if defined(OS_POSIX) 21 #if defined(OS_POSIX)
19 22
20 #include <errno.h> 23 #include <errno.h>
21 24
22 #if defined(NDEBUG) 25 #if defined(NDEBUG)
26
23 #define HANDLE_EINTR(x) ({ \ 27 #define HANDLE_EINTR(x) ({ \
24 typeof(x) eintr_wrapper_result; \ 28 typeof(x) eintr_wrapper_result; \
25 do { \ 29 do { \
26 eintr_wrapper_result = (x); \ 30 eintr_wrapper_result = (x); \
27 } while (eintr_wrapper_result == -1 && errno == EINTR); \ 31 } while (eintr_wrapper_result == -1 && errno == EINTR); \
28 eintr_wrapper_result; \ 32 eintr_wrapper_result; \
29 }) 33 })
30 34
31 #else 35 #else
32 36
33 #define HANDLE_EINTR(x) ({ \ 37 #define HANDLE_EINTR(x) ({ \
34 int eintr_wrapper_counter = 0; \ 38 int eintr_wrapper_counter = 0; \
35 typeof(x) eintr_wrapper_result; \ 39 typeof(x) eintr_wrapper_result; \
36 do { \ 40 do { \
37 eintr_wrapper_result = (x); \ 41 eintr_wrapper_result = (x); \
38 } while (eintr_wrapper_result == -1 && errno == EINTR && \ 42 } while (eintr_wrapper_result == -1 && errno == EINTR && \
39 eintr_wrapper_counter++ < 100); \ 43 eintr_wrapper_counter++ < 100); \
40 eintr_wrapper_result; \ 44 eintr_wrapper_result; \
41 }) 45 })
42 46
43 #endif // NDEBUG 47 #endif // NDEBUG
44 48
49 #define IGNORE_EINTR(x) ({ \
50 typeof(x) eintr_wrapper_result; \
51 do { \
52 eintr_wrapper_result = (x); \
53 if (eintr_wrapper_result == -1 && errno == EINTR) { \
54 eintr_wrapper_result = 0; \
55 } \
56 } while (0); \
57 eintr_wrapper_result; \
58 })
59
45 #else 60 #else
46 61
47 #define HANDLE_EINTR(x) (x) 62 #define HANDLE_EINTR(x) (x)
63 #define IGNORE_EINTR(x) (x)
48 64
49 #endif // OS_POSIX 65 #endif // OS_POSIX
50 66
51 #endif // BASE_POSIX_EINTR_WRAPPER_H_ 67 #endif // BASE_POSIX_EINTR_WRAPPER_H_
OLDNEW
« no previous file with comments | « base/platform_file_posix.cc ('k') | base/posix/file_descriptor_shuffle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698