net/base/address_tracker_linux.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/address_tracker_linux.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/address_tracker_linux.cc

diff --git a/net/base/address_tracker_linux.cc b/net/base/address_tracker_linux.cc

index 886811a7919acf5b9339f8061d5cefb09e827116..f863ccd625bb8e7056e90a996531b83cbb5357e1 100644

--- a/net/base/address_tracker_linux.cc

+++ b/net/base/address_tracker_linux.cc

@@ -306,7 +306,7 @@ void AddressTrackerLinux::OnFileCanReadWithoutBlocking(int fd) {

void AddressTrackerLinux::OnFileCanWriteWithoutBlocking(int /* fd */) {}

void AddressTrackerLinux::CloseSocket() {

- if (netlink_fd_ >= 0 && HANDLE_EINTR(close(netlink_fd_)) < 0)

+ if (netlink_fd_ >= 0 && IGNORE_EINTR(close(netlink_fd_)) < 0)

PLOG(ERROR) << "Could not close NETLINK socket.";

netlink_fd_ = -1;

}

« no previous file with comments | « media/base/user_input_monitor_linux.cc ('k') | net/base/net_util_posix.cc » ('j') | no next file with comments »