Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3967)

Unified Diff: content/browser/renderer_host/render_sandbox_host_linux.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_sandbox_host_linux.cc
diff --git a/content/browser/renderer_host/render_sandbox_host_linux.cc b/content/browser/renderer_host/render_sandbox_host_linux.cc
index b35ac7365b53666510eadfd7e8a1843e94e9d3a0..a018043b648c4a41cc4c8c130328ff2fb02caff9 100644
--- a/content/browser/renderer_host/render_sandbox_host_linux.cc
+++ b/content/browser/renderer_host/render_sandbox_host_linux.cc
@@ -241,7 +241,7 @@ class SandboxIPCProcess {
SendRendererReply(fds, reply, result_fd);
if (result_fd >= 0) {
- int err = HANDLE_EINTR(close(result_fd));
+ int err = IGNORE_EINTR(close(result_fd));
DCHECK(!err);
}
}
@@ -516,7 +516,7 @@ class SandboxIPCProcess {
SendRendererReply(fds, reply, font_fd);
if (font_fd >= 0) {
- if (HANDLE_EINTR(close(font_fd)) < 0)
+ if (IGNORE_EINTR(close(font_fd)) < 0)
PLOG(ERROR) << "close";
}
}
@@ -718,9 +718,9 @@ void RenderSandboxHostLinux::Init(const std::string& sandbox_path) {
#endif
pid_ = fork();
if (pid_ == 0) {
- if (HANDLE_EINTR(close(fds[0])) < 0)
+ if (IGNORE_EINTR(close(fds[0])) < 0)
DPLOG(ERROR) << "close";
- if (HANDLE_EINTR(close(pipefds[1])) < 0)
+ if (IGNORE_EINTR(close(pipefds[1])) < 0)
DPLOG(ERROR) << "close";
SandboxIPCProcess handler(child_lifeline_fd, browser_socket, sandbox_path);
@@ -731,9 +731,9 @@ void RenderSandboxHostLinux::Init(const std::string& sandbox_path) {
RenderSandboxHostLinux::~RenderSandboxHostLinux() {
if (initialized_) {
- if (HANDLE_EINTR(close(renderer_socket_)) < 0)
+ if (IGNORE_EINTR(close(renderer_socket_)) < 0)
PLOG(ERROR) << "close";
- if (HANDLE_EINTR(close(childs_lifeline_fd_)) < 0)
+ if (IGNORE_EINTR(close(childs_lifeline_fd_)) < 0)
PLOG(ERROR) << "close";
}
}
« no previous file with comments | « components/nacl/zygote/nacl_fork_delegate_linux.cc ('k') | content/browser/renderer_host/render_widget_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698