chromeos/process_proxy/process_output_watcher.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/process_proxy/process_output_watcher.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/process_proxy/process_output_watcher.cc

diff --git a/chromeos/process_proxy/process_output_watcher.cc b/chromeos/process_proxy/process_output_watcher.cc

index 40ed8cf63579e179422fd8a04c257c08d016241a..f0639846424f6b10225d5a698830f9491f36a036 100644

--- a/chromeos/process_proxy/process_output_watcher.cc

+++ b/chromeos/process_proxy/process_output_watcher.cc

@@ -26,7 +26,7 @@ void InitReadFdSet(int out_fd, int stop_fd, fd_set* set) {

void CloseFd(int* fd) {

if (*fd >= 0) {

- if (HANDLE_EINTR(close(*fd)) != 0)

+ if (IGNORE_EINTR(close(*fd)) != 0)

DPLOG(WARNING) << "close fd " << *fd << " failed.";

}

*fd = -1;