net/udp/udp_socket_libevent.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/udp/udp_socket_libevent.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/udp/udp_socket_libevent.cc

diff --git a/net/udp/udp_socket_libevent.cc b/net/udp/udp_socket_libevent.cc

index 990aa5758cca8f463ec0caf615432091a2847ac1..7ef9c3c6b79681cfa99a5e2acafd7325a8ac66ad 100644

--- a/net/udp/udp_socket_libevent.cc

+++ b/net/udp/udp_socket_libevent.cc

@@ -83,7 +83,7 @@ void UDPSocketLibevent::Close() {

ok = write_socket_watcher_.StopWatchingFileDescriptor();

DCHECK(ok);

- if (HANDLE_EINTR(close(socket_)) < 0)

+ if (IGNORE_EINTR(close(socket_)) < 0)

PLOG(ERROR) << "close";

socket_ = kInvalidSocket;

« no previous file with comments | « net/socket/unix_domain_socket_posix_unittest.cc ('k') | net/udp/udp_socket_win.cc » ('j') | no next file with comments »