Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: tools/android/forwarder2/common.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/android/forwarder/forwarder.cc ('k') | tools/android/forwarder2/host_forwarder_main.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/android/forwarder2/common.h" 5 #include "tools/android/forwarder2/common.h"
6 6
7 #include <errno.h> 7 #include <errno.h>
8 #include <unistd.h> 8 #include <unistd.h>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/posix/eintr_wrapper.h" 11 #include "base/posix/eintr_wrapper.h"
12 #include "base/safe_strerror_posix.h" 12 #include "base/safe_strerror_posix.h"
13 13
14 namespace forwarder2 { 14 namespace forwarder2 {
15 15
16 void PError(const char* msg) { 16 void PError(const char* msg) {
17 LOG(ERROR) << msg << ": " << safe_strerror(errno); 17 LOG(ERROR) << msg << ": " << safe_strerror(errno);
18 } 18 }
19 19
20 void CloseFD(int fd) { 20 void CloseFD(int fd) {
21 const int errno_copy = errno; 21 const int errno_copy = errno;
22 if (HANDLE_EINTR(close(fd)) < 0) { 22 if (IGNORE_EINTR(close(fd)) < 0) {
23 PError("close"); 23 PError("close");
24 errno = errno_copy; 24 errno = errno_copy;
25 } 25 }
26 } 26 }
27 27
28 } // namespace forwarder2 28 } // namespace forwarder2
OLDNEW
« no previous file with comments | « tools/android/forwarder/forwarder.cc ('k') | tools/android/forwarder2/host_forwarder_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698