tools/android/forwarder2/common.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/forwarder2/common.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/android/forwarder2/common.cc

diff --git a/tools/android/forwarder2/common.cc b/tools/android/forwarder2/common.cc

index c97ed8056b7285684e78c18b1eec8069206ba50e..3b7387d3a62b1e1cf113618b959fd03ff0a9b309 100644

--- a/tools/android/forwarder2/common.cc

+++ b/tools/android/forwarder2/common.cc

@@ -19,7 +19,7 @@ void PError(const char* msg) {

void CloseFD(int fd) {

const int errno_copy = errno;

- if (HANDLE_EINTR(close(fd)) < 0) {

+ if (IGNORE_EINTR(close(fd)) < 0) {

PError("close");

errno = errno_copy;

}