base/files/memory_mapped_file_posix.cc - Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/memory_mapped_file_posix.cc

Issue 100253002: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/files/memory_mapped_file_posix.cc

diff --git a/base/files/memory_mapped_file_posix.cc b/base/files/memory_mapped_file_posix.cc

index ba00946722c7962da445261b89cb2e82b2c7cd85..c4c477a3fe71944903c486107d90336a26258a91 100644

--- a/base/files/memory_mapped_file_posix.cc

+++ b/base/files/memory_mapped_file_posix.cc

@@ -9,7 +9,6 @@

#include <unistd.h>

#include "base/logging.h"

-#include "base/posix/eintr_wrapper.h"

#include "base/threading/thread_restrictions.h"

namespace base {

@@ -44,7 +43,7 @@ void MemoryMappedFile::CloseHandles() {

if (data_ != NULL)

munmap(data_, length_);

if (file_ != kInvalidPlatformFileValue)

- ignore_result(HANDLE_EINTR(close(file_)));

+ close(file_);

data_ = NULL;

length_ = 0;

« no previous file with comments | « base/files/file_posix.cc ('k') | base/memory/discardable_memory_android.cc » ('j') | no next file with comments »