Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
maniscalco
CC:
cbentzel+watch_chromium.org, chromium-reviews, maniscalco+watch_chromium.org, pvalenzuela+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in sync/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=maniscalco@chromium.org Committed: https://crrev.com/393acf28e5f1fd88de91c916c36d83d844021b0a Cr-Commit-Position: refs/heads/master@{#300499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+885 lines, -1006 lines) Patch
M sync/api/attachments/attachment_store.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/api/fake_sync_change_processor.h View 1 chunk +6 lines, -8 lines 0 comments Download
M sync/api/fake_syncable_service.h View 2 chunks +6 lines, -7 lines 0 comments Download
M sync/api/sync_change_processor_wrapper_for_test.h View 1 chunk +3 lines, -4 lines 0 comments Download
M sync/api/syncable_service.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/all_status.h View 1 chunk +7 lines, -7 lines 0 comments Download
M sync/engine/directory_commit_contribution.h View 3 chunks +5 lines, -5 lines 0 comments Download
M sync/engine/directory_commit_contributor.h View 1 chunk +2 lines, -3 lines 0 comments Download
M sync/engine/directory_update_handler.h View 1 chunk +6 lines, -7 lines 0 comments Download
M sync/engine/get_updates_delegate.h View 3 chunks +21 lines, -21 lines 0 comments Download
M sync/engine/model_type_sync_worker_impl.h View 2 chunks +8 lines, -11 lines 0 comments Download
M sync/engine/net/server_connection_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/engine/non_blocking_type_commit_contribution.h View 1 chunk +5 lines, -5 lines 0 comments Download
M sync/engine/sync_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/sync_scheduler_impl.h View 1 chunk +22 lines, -24 lines 0 comments Download
M sync/engine/syncer_proto_util_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M sync/engine/syncer_unittest.cc View 5 chunks +24 lines, -31 lines 0 comments Download
M sync/internal_api/attachments/attachment_downloader_impl_unittest.cc View 2 chunks +16 lines, -16 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_impl_unittest.cc View 5 chunks +12 lines, -13 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_proxy_unittest.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M sync/internal_api/attachments/attachment_store_handle_unittest.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M sync/internal_api/attachments/attachment_uploader_impl.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M sync/internal_api/attachments/attachment_uploader_impl_unittest.cc View 3 chunks +16 lines, -16 lines 0 comments Download
M sync/internal_api/debug_info_event_listener.h View 1 chunk +23 lines, -28 lines 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/js_mutation_event_observer.h View 2 chunks +6 lines, -7 lines 0 comments Download
M sync/internal_api/js_sync_encryption_handler_observer.h View 1 chunk +11 lines, -15 lines 0 comments Download
M sync/internal_api/js_sync_manager_observer.h View 1 chunk +7 lines, -9 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_downloader_impl.h View 1 chunk +9 lines, -9 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_service_impl.h View 1 chunk +8 lines, -10 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_service_proxy.h View 2 chunks +13 lines, -16 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_service_proxy_for_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_store_handle.h View 1 chunk +5 lines, -7 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_uploader_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/attachments/fake_attachment_downloader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/attachments/fake_attachment_uploader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/attachments/in_memory_attachment_store.h View 1 chunk +5 lines, -7 lines 0 comments Download
M sync/internal_api/public/attachments/on_disk_attachment_store.h View 1 chunk +5 lines, -7 lines 0 comments Download
M sync/internal_api/public/base/cancelation_signal_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/engine/model_safe_worker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/engine/passive_model_worker.h View 1 chunk +4 lines, -5 lines 0 comments Download
M sync/internal_api/public/events/commit_request_event.h View 1 chunk +6 lines, -6 lines 0 comments Download
M sync/internal_api/public/events/commit_response_event.h View 1 chunk +6 lines, -6 lines 0 comments Download
M sync/internal_api/public/events/configure_get_updates_request_event.h View 1 chunk +6 lines, -6 lines 0 comments Download
M sync/internal_api/public/events/get_updates_response_event.h View 1 chunk +6 lines, -6 lines 0 comments Download
M sync/internal_api/public/events/normal_get_updates_request_event.h View 1 chunk +6 lines, -6 lines 0 comments Download
M sync/internal_api/public/events/poll_get_updates_request_event.h View 1 chunk +6 lines, -6 lines 0 comments Download
M sync/internal_api/public/http_bridge.h View 4 chunks +22 lines, -22 lines 0 comments Download
M sync/internal_api/public/http_bridge_network_resources.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/internal_components_factory_impl.h View 2 chunks +8 lines, -8 lines 0 comments Download
M sync/internal_api/public/read_node.h View 2 chunks +6 lines, -7 lines 0 comments Download
M sync/internal_api/public/read_transaction.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/test/fake_sync_manager.h View 3 chunks +35 lines, -38 lines 0 comments Download
M sync/internal_api/public/test/null_sync_context_proxy.h View 1 chunk +4 lines, -4 lines 0 comments Download
M sync/internal_api/public/test/sync_manager_factory_for_profile_sync_test.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/test/test_internal_components_factory.h View 2 chunks +5 lines, -6 lines 0 comments Download
M sync/internal_api/public/write_node.h View 2 chunks +6 lines, -7 lines 0 comments Download
M sync/internal_api/public/write_transaction.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_backup_manager.h View 1 chunk +10 lines, -10 lines 0 comments Download
M sync/internal_api/sync_context_proxy_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M sync/internal_api/sync_encryption_handler_impl.h View 1 chunk +16 lines, -18 lines 0 comments Download
M sync/internal_api/sync_manager_impl.h View 1 chunk +62 lines, -70 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 5 chunks +25 lines, -31 lines 0 comments Download
M sync/internal_api/sync_rollback_manager.h View 1 chunk +3 lines, -4 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_base.h View 2 chunks +39 lines, -42 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_base.cc View 1 chunk +9 lines, -12 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/syncapi_server_connection_manager.h View 2 chunks +8 lines, -8 lines 0 comments Download
M sync/internal_api/syncapi_server_connection_manager_unittest.cc View 1 chunk +16 lines, -23 lines 0 comments Download
M sync/internal_api/test/sync_manager_for_profile_sync_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/js/sync_js_controller.h View 1 chunk +5 lines, -5 lines 0 comments Download
M sync/sessions/model_type_registry.h View 3 chunks +13 lines, -14 lines 0 comments Download
M sync/sessions/model_type_registry.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M sync/syncable/deferred_on_disk_directory_backing_store.h View 1 chunk +5 lines, -7 lines 0 comments Download
M sync/syncable/directory_backing_store_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/syncable/directory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/in_memory_directory_backing_store.h View 1 chunk +3 lines, -4 lines 0 comments Download
M sync/syncable/invalid_directory_backing_store.h View 1 chunk +5 lines, -5 lines 0 comments Download
M sync/syncable/on_disk_directory_backing_store.h View 1 chunk +4 lines, -5 lines 0 comments Download
M sync/syncable/syncable_base_write_transaction.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/syncable_model_neutral_write_transaction.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/syncable/syncable_read_transaction.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/syncable_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M sync/syncable/syncable_write_transaction.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/test/accounts_client/test_accounts_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/accounts_client/url_request_context_getter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M sync/test/engine/fake_model_worker.h View 1 chunk +4 lines, -5 lines 0 comments Download
M sync/test/engine/fake_sync_scheduler.h View 1 chunk +22 lines, -27 lines 0 comments Download
M sync/test/engine/injectable_sync_context_proxy.h View 1 chunk +9 lines, -10 lines 0 comments Download
M sync/test/engine/mock_connection_manager.h View 1 chunk +5 lines, -6 lines 0 comments Download
M sync/test/engine/mock_model_type_sync_proxy.h View 1 chunk +6 lines, -8 lines 0 comments Download
M sync/test/engine/mock_model_type_sync_worker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/test/engine/mock_nudge_handler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M sync/test/engine/mock_update_handler.h View 1 chunk +6 lines, -7 lines 0 comments Download
M sync/test/fake_encryptor.h View 1 chunk +5 lines, -5 lines 0 comments Download
M sync/test/fake_server/bookmark_entity.h View 2 chunks +5 lines, -5 lines 0 comments Download
M sync/test/fake_server/bookmark_entity_builder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/test/fake_server/fake_server_http_post_provider.h View 2 chunks +15 lines, -15 lines 0 comments Download
M sync/test/fake_server/fake_server_network_resources.h View 1 chunk +6 lines, -7 lines 0 comments Download
M sync/test/fake_server/permanent_entity.h View 2 chunks +5 lines, -5 lines 0 comments Download
M sync/test/fake_server/tombstone_entity.h View 1 chunk +5 lines, -5 lines 0 comments Download
M sync/test/fake_server/unique_client_entity.h View 2 chunks +5 lines, -5 lines 0 comments Download
M sync/test/fake_sync_encryption_handler.h View 1 chunk +16 lines, -18 lines 0 comments Download
M sync/test/local_sync_test_server.h View 1 chunk +4 lines, -6 lines 0 comments Download
M sync/test/mock_invalidation.h View 1 chunk +6 lines, -6 lines 0 comments Download
M sync/test/null_directory_change_delegate.h View 1 chunk +5 lines, -5 lines 0 comments Download
M sync/test/sessions/mock_debug_info_getter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/test/test_directory_backing_store.h View 1 chunk +4 lines, -5 lines 0 comments Download
M sync/test/test_transaction_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/test/trackable_mock_invalidation.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/tools/null_invalidation_state_tracker.h View 1 chunk +8 lines, -9 lines 0 comments Download
M sync/tools/sync_client.cc View 11 chunks +29 lines, -39 lines 0 comments Download
M sync/tools/sync_listen_notifications.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M sync/util/test_unrecoverable_error_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
dcheng
6 years, 2 months ago (2014-10-21 09:35:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642023004/1
6 years, 2 months ago (2014-10-21 09:36:54 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/27522)
6 years, 2 months ago (2014-10-21 10:52:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642023004/1
6 years, 2 months ago (2014-10-21 11:49:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/27576)
6 years, 2 months ago (2014-10-21 13:20:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642023004/1
6 years, 2 months ago (2014-10-21 15:44:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 16:45:17 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 16:46:14 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/393acf28e5f1fd88de91c916c36d83d844021b0a
Cr-Commit-Position: refs/heads/master@{#300499}

Powered by Google App Engine
This is Rietveld 408576698