sync/internal_api/public/attachments/in_memory_attachment_store.h - Issue 642023004: Standardize usage of virtual/override/final in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/attachments/in_memory_attachment_store.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/public/attachments/fake_attachment_uploader.h ('k') | sync/internal_api/public/attachments/on_disk_attachment_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/attachments/in_memory_attachment_store.h

diff --git a/sync/internal_api/public/attachments/in_memory_attachment_store.h b/sync/internal_api/public/attachments/in_memory_attachment_store.h

index adf4035a9173b7c0d9fcd8dc2509d4d8b367e351..c586ef0ef16feb0037b309e41fbb21fdf448dd62 100644

--- a/sync/internal_api/public/attachments/in_memory_attachment_store.h

+++ b/sync/internal_api/public/attachments/in_memory_attachment_store.h

@@ -23,15 +23,13 @@ class SYNC_EXPORT InMemoryAttachmentStore : public AttachmentStoreBase,

public:

InMemoryAttachmentStore(

const scoped_refptr<base::SingleThreadTaskRunner>& callback_task_runner);

- virtual ~InMemoryAttachmentStore();

+ ~InMemoryAttachmentStore() override;

// AttachmentStoreBase implementation.

- virtual void Read(const AttachmentIdList& ids,

- const ReadCallback& callback) override;

- virtual void Write(const AttachmentList& attachments,

- const WriteCallback& callback) override;

- virtual void Drop(const AttachmentIdList& ids,

- const DropCallback& callback) override;

+ void Read(const AttachmentIdList& ids, const ReadCallback& callback) override;

+ void Write(const AttachmentList& attachments,

+ const WriteCallback& callback) override;

+ void Drop(const AttachmentIdList& ids, const DropCallback& callback) override;

private:

scoped_refptr<base::SingleThreadTaskRunner> callback_task_runner_;