sync/internal_api/public/attachments/fake_attachment_downloader.h - Issue 642023004: Standardize usage of virtual/override/final in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/attachments/fake_attachment_downloader.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/public/attachments/attachment_uploader_impl.h ('k') | sync/internal_api/public/attachments/fake_attachment_uploader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/attachments/fake_attachment_downloader.h

diff --git a/sync/internal_api/public/attachments/fake_attachment_downloader.h b/sync/internal_api/public/attachments/fake_attachment_downloader.h

index 0b13a0ec9693259c293d68e24f801c497d9a299a..576d06be6617f9549822e355336181c36cb8fc36 100644

--- a/sync/internal_api/public/attachments/fake_attachment_downloader.h

+++ b/sync/internal_api/public/attachments/fake_attachment_downloader.h

@@ -16,11 +16,11 @@ class SYNC_EXPORT FakeAttachmentDownloader : public AttachmentDownloader,

public base::NonThreadSafe {

public:

FakeAttachmentDownloader();

- virtual ~FakeAttachmentDownloader();

+ ~FakeAttachmentDownloader() override;

// AttachmentDownloader implementation.

- virtual void DownloadAttachment(const AttachmentId& attachment_id,

- const DownloadCallback& callback) override;

+ void DownloadAttachment(const AttachmentId& attachment_id,

+ const DownloadCallback& callback) override;

private:

DISALLOW_COPY_AND_ASSIGN(FakeAttachmentDownloader);