sync/internal_api/public/events/commit_response_event.h - Issue 642023004: Standardize usage of virtual/override/final in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/events/commit_response_event.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/public/events/commit_request_event.h ('k') | sync/internal_api/public/events/configure_get_updates_request_event.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/events/commit_response_event.h

diff --git a/sync/internal_api/public/events/commit_response_event.h b/sync/internal_api/public/events/commit_response_event.h

index 0fba20386c0d72a14aec9bf5c569b5913d488449..4de828379e59d2bf8942d7de6ab5b93dc570f32d 100644

--- a/sync/internal_api/public/events/commit_response_event.h

+++ b/sync/internal_api/public/events/commit_response_event.h

@@ -24,13 +24,13 @@ class SYNC_EXPORT_PRIVATE CommitResponseEvent : public ProtocolEvent {

base::Time timestamp,

SyncerError result,

const sync_pb::ClientToServerResponse& response);

- virtual ~CommitResponseEvent();

+ ~CommitResponseEvent() override;

- virtual base::Time GetTimestamp() const override;

- virtual std::string GetType() const override;

- virtual std::string GetDetails() const override;

- virtual scoped_ptr<base::DictionaryValue> GetProtoMessage() const override;

- virtual scoped_ptr<ProtocolEvent> Clone() const override;

+ base::Time GetTimestamp() const override;

+ std::string GetType() const override;

+ std::string GetDetails() const override;

+ scoped_ptr<base::DictionaryValue> GetProtoMessage() const override;

+ scoped_ptr<ProtocolEvent> Clone() const override;

static scoped_ptr<base::DictionaryValue> ToValue(

const ProtocolEvent& event);