Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: sync/internal_api/sync_context_proxy_impl.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SYNC_INTERNAL_API_SYNC_CONTEXT_PROXY_IMPL_H_ 5 #ifndef SYNC_INTERNAL_API_SYNC_CONTEXT_PROXY_IMPL_H_
6 #define SYNC_INTERNAL_API_SYNC_CONTEXT_PROXY_IMPL_H_ 6 #define SYNC_INTERNAL_API_SYNC_CONTEXT_PROXY_IMPL_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "base/sequenced_task_runner.h" 10 #include "base/sequenced_task_runner.h"
(...skipping 10 matching lines...) Expand all
21 // Encapsulates a reference to the sync context and the thread it's running on. 21 // Encapsulates a reference to the sync context and the thread it's running on.
22 // Used by sync's data types to connect with the sync context. 22 // Used by sync's data types to connect with the sync context.
23 // 23 //
24 // It is expected that this object will be copied to and used on many different 24 // It is expected that this object will be copied to and used on many different
25 // threads. It is small and safe to pass by value. 25 // threads. It is small and safe to pass by value.
26 class SYNC_EXPORT_PRIVATE SyncContextProxyImpl : public SyncContextProxy { 26 class SYNC_EXPORT_PRIVATE SyncContextProxyImpl : public SyncContextProxy {
27 public: 27 public:
28 SyncContextProxyImpl( 28 SyncContextProxyImpl(
29 const scoped_refptr<base::SequencedTaskRunner>& sync_task_runner, 29 const scoped_refptr<base::SequencedTaskRunner>& sync_task_runner,
30 const base::WeakPtr<SyncContext>& sync_context); 30 const base::WeakPtr<SyncContext>& sync_context);
31 virtual ~SyncContextProxyImpl(); 31 ~SyncContextProxyImpl() override;
32 32
33 // Attempts to connect a non-blocking type to the sync context. 33 // Attempts to connect a non-blocking type to the sync context.
34 // 34 //
35 // This may fail under some unusual circumstances, like shutdown. Due to the 35 // This may fail under some unusual circumstances, like shutdown. Due to the
36 // nature of WeakPtrs and cross-thread communication, the caller will be 36 // nature of WeakPtrs and cross-thread communication, the caller will be
37 // unable to distinguish a slow success from failure. 37 // unable to distinguish a slow success from failure.
38 // 38 //
39 // Must be called from the thread where the data type lives. 39 // Must be called from the thread where the data type lives.
40 virtual void ConnectTypeToSync( 40 void ConnectTypeToSync(
41 syncer::ModelType type, 41 syncer::ModelType type,
42 const DataTypeState& data_type_state, 42 const DataTypeState& data_type_state,
43 const UpdateResponseDataList& pending_updates, 43 const UpdateResponseDataList& pending_updates,
44 const base::WeakPtr<ModelTypeSyncProxyImpl>& sync_proxy_impl) override; 44 const base::WeakPtr<ModelTypeSyncProxyImpl>& sync_proxy_impl) override;
45 45
46 // Disables syncing for the given type on the sync thread. 46 // Disables syncing for the given type on the sync thread.
47 virtual void Disconnect(syncer::ModelType type) override; 47 void Disconnect(syncer::ModelType type) override;
48 48
49 virtual scoped_ptr<SyncContextProxy> Clone() const override; 49 scoped_ptr<SyncContextProxy> Clone() const override;
50 50
51 private: 51 private:
52 // A SequencedTaskRunner representing the thread where the SyncContext lives. 52 // A SequencedTaskRunner representing the thread where the SyncContext lives.
53 scoped_refptr<base::SequencedTaskRunner> sync_task_runner_; 53 scoped_refptr<base::SequencedTaskRunner> sync_task_runner_;
54 54
55 // The SyncContext this object is wrapping. 55 // The SyncContext this object is wrapping.
56 base::WeakPtr<SyncContext> sync_context_; 56 base::WeakPtr<SyncContext> sync_context_;
57 }; 57 };
58 58
59 } // namespace syncer 59 } // namespace syncer
60 60
61 #endif // SYNC_INTERNAL_API_SYNC_CONTEXT_PROXY_IMPL_H_ 61 #endif // SYNC_INTERNAL_API_SYNC_CONTEXT_PROXY_IMPL_H_
OLDNEW
« no previous file with comments | « sync/internal_api/sync_backup_manager.h ('k') | sync/internal_api/sync_encryption_handler_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698