Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: sync/internal_api/public/read_node.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/public/read_node.h
diff --git a/sync/internal_api/public/read_node.h b/sync/internal_api/public/read_node.h
index 6d46eea70f6907f3b7dc8ad1172b2020a76b94ca..5749f9c3a0cce6e5d8cad183c290c16aaddd3718 100644
--- a/sync/internal_api/public/read_node.h
+++ b/sync/internal_api/public/read_node.h
@@ -22,16 +22,15 @@ class SYNC_EXPORT ReadNode : public BaseNode {
// Create an unpopulated ReadNode on the given transaction. Call some flavor
// of Init to populate the ReadNode with a database entry.
explicit ReadNode(const BaseTransaction* transaction);
- virtual ~ReadNode();
+ ~ReadNode() override;
// A client must use one (and only one) of the following Init variants to
// populate the node.
// BaseNode implementation.
- virtual InitByLookupResult InitByIdLookup(int64 id) override;
- virtual InitByLookupResult InitByClientTagLookup(
- ModelType model_type,
- const std::string& tag) override;
+ InitByLookupResult InitByIdLookup(int64 id) override;
+ InitByLookupResult InitByClientTagLookup(ModelType model_type,
+ const std::string& tag) override;
// There is always a root node, so this can't fail. The root node is
// never mutable, so root lookup is only possible on a ReadNode.
@@ -50,8 +49,8 @@ class SYNC_EXPORT ReadNode : public BaseNode {
InitByLookupResult InitByTagLookupForBookmarks(const std::string& tag);
// Implementation of BaseNode's abstract virtual accessors.
- virtual const syncable::Entry* GetEntry() const override;
- virtual const BaseTransaction* GetTransaction() const override;
+ const syncable::Entry* GetEntry() const override;
+ const BaseTransaction* GetTransaction() const override;
protected:
ReadNode();
« no previous file with comments | « sync/internal_api/public/internal_components_factory_impl.h ('k') | sync/internal_api/public/read_transaction.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698