sync/internal_api/public/read_transaction.h - Issue 642023004: Standardize usage of virtual/override/final in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/read_transaction.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/internal_api/public/read_transaction.h

diff --git a/sync/internal_api/public/read_transaction.h b/sync/internal_api/public/read_transaction.h

index 364f6be612ef1e5f2d068e7d843c981c551a8e68..2084b9acbeb1acd0bf4cc1f68c9c5884b0e00566 100644

--- a/sync/internal_api/public/read_transaction.h

+++ b/sync/internal_api/public/read_transaction.h

@@ -33,10 +33,10 @@ class SYNC_EXPORT ReadTransaction : public BaseTransaction {

// Resume the middle of a transaction. Will not close transaction.

ReadTransaction(UserShare* share, syncable::BaseTransaction* trans);

- virtual ~ReadTransaction();

+ ~ReadTransaction() override;

// BaseTransaction override.

- virtual syncable::BaseTransaction* GetWrappedTrans() const override;

+ syncable::BaseTransaction* GetWrappedTrans() const override;

// Return |transaction_version| of |type| stored in sync directory's

// persisted info.

« no previous file with comments | « sync/internal_api/public/read_node.h ('k') | sync/internal_api/public/test/fake_sync_manager.h » ('j') | no next file with comments »