sync/api/syncable_service.h - Issue 642023004: Standardize usage of virtual/override/final in sync/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sync/api/syncable_service.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « sync/api/sync_change_processor_wrapper_for_test.h ('k') | sync/engine/all_status.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2012 The Chromium Authors. All rights reserved.	1 // Copyright 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef SYNC_API_SYNCABLE_SERVICE_H_	5 #ifndef SYNC_API_SYNCABLE_SERVICE_H_

6 #define SYNC_API_SYNCABLE_SERVICE_H_	6 #define SYNC_API_SYNCABLE_SERVICE_H_

7	7

8 #include <vector>	8 #include <vector>

9	9

10 #include "base/callback.h"	10 #include "base/callback.h"

(...skipping 59 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
70 // when uploading or downloading attachments.	70 // when uploading or downloading attachments.

71 // GetAttachmentStore is called right before MergeDataAndStartSyncing. If at	71 // GetAttachmentStore is called right before MergeDataAndStartSyncing. If at

72 // that time GetAttachmentStore returns NULL then datatype is considered not	72 // that time GetAttachmentStore returns NULL then datatype is considered not

73 // using attachments and all attempts to upload/download attachments will	73 // using attachments and all attempts to upload/download attachments will

74 // fail. Default implementation returns NULL. Datatype that uses sync	74 // fail. Default implementation returns NULL. Datatype that uses sync

75 // attachemnts should create attachment store and implement GetAttachmentStore	75 // attachemnts should create attachment store and implement GetAttachmentStore

76 // to return pointer to it.	76 // to return pointer to it.

77 virtual scoped_refptr<AttachmentStore> GetAttachmentStore();	77 virtual scoped_refptr<AttachmentStore> GetAttachmentStore();

78	78

79 protected:	79 protected:

80 virtual ~SyncableService();	80 ~SyncableService() override;

81 };	81 };

82	82

83 } // namespace syncer	83 } // namespace syncer

84	84

85 #endif // SYNC_API_SYNCABLE_SERVICE_H_	85 #endif // SYNC_API_SYNCABLE_SERVICE_H_

OLD	NEW