sync/syncable/syncable_read_transaction.h - Issue 642023004: Standardize usage of virtual/override/final in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/syncable_read_transaction.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/syncable/syncable_read_transaction.h

diff --git a/sync/syncable/syncable_read_transaction.h b/sync/syncable/syncable_read_transaction.h

index 2b9729d4662d8aee840499a92a94a19c68753306..a13f92f68a5333a41b3ae46cae77ddb760bdec95 100644

--- a/sync/syncable/syncable_read_transaction.h

+++ b/sync/syncable/syncable_read_transaction.h

@@ -18,7 +18,7 @@ class SYNC_EXPORT ReadTransaction : public BaseTransaction {

ReadTransaction(const tracked_objects::Location& from_here,

Directory* directory);

- virtual ~ReadTransaction();

+ ~ReadTransaction() override;

protected: // Don't allow creation on heap, except by sync API wrapper.

friend class syncer::ReadTransaction;

« no previous file with comments | « sync/syncable/syncable_model_neutral_write_transaction.h ('k') | sync/syncable/syncable_unittest.cc » ('j') | no next file with comments »