sync/internal_api/public/attachments/attachment_service_proxy_for_test.h - Issue 642023004: Standardize usage of virtual/override/final in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/attachments/attachment_service_proxy_for_test.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/public/attachments/attachment_service_proxy.h ('k') | sync/internal_api/public/attachments/attachment_store_handle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/attachments/attachment_service_proxy_for_test.h

diff --git a/sync/internal_api/public/attachments/attachment_service_proxy_for_test.h b/sync/internal_api/public/attachments/attachment_service_proxy_for_test.h

index b5cbdcaaae5933e07afa871cc1bc2622ef7ee315..47a990b75aaccecae56abab00df8fab5d7229a22 100644

--- a/sync/internal_api/public/attachments/attachment_service_proxy_for_test.h

+++ b/sync/internal_api/public/attachments/attachment_service_proxy_for_test.h

@@ -21,7 +21,7 @@ class SYNC_EXPORT AttachmentServiceProxyForTest

: public AttachmentServiceProxy {

public:

static AttachmentServiceProxy Create();

- virtual ~AttachmentServiceProxyForTest();

+ ~AttachmentServiceProxyForTest() override;

private:

// A Core that owns the wrapped AttachmentService.

@@ -32,7 +32,7 @@ class SYNC_EXPORT AttachmentServiceProxyForTest

scoped_ptr<base::WeakPtrFactory<AttachmentService> > weak_ptr_factory);

private:

- virtual ~OwningCore();

+ ~OwningCore() override;

scoped_ptr<AttachmentService> wrapped_;

// WeakPtrFactory for wrapped_. See Create() for why this is a scoped_ptr.