sync/internal_api/public/engine/model_safe_worker.h - Issue 642023004: Standardize usage of virtual/override/final in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/engine/model_safe_worker.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/public/base/cancelation_signal_unittest.cc ('k') | sync/internal_api/public/engine/passive_model_worker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/engine/model_safe_worker.h

diff --git a/sync/internal_api/public/engine/model_safe_worker.h b/sync/internal_api/public/engine/model_safe_worker.h

index df5bba9b7b10109863c29c281aeaf8575e0f67b5..ad84d4925cffae2f49fcaacf4c97e3eb7084c78a 100644

--- a/sync/internal_api/public/engine/model_safe_worker.h

+++ b/sync/internal_api/public/engine/model_safe_worker.h

@@ -89,13 +89,13 @@ class SYNC_EXPORT ModelSafeWorker

virtual ModelSafeGroup GetModelSafeGroup() = 0;

// MessageLoop::DestructionObserver implementation.

- virtual void WillDestroyCurrentMessageLoop() override;

+ void WillDestroyCurrentMessageLoop() override;

protected:

friend class base::RefCountedThreadSafe<ModelSafeWorker>;

explicit ModelSafeWorker(WorkerLoopDestructionObserver* observer);

- virtual ~ModelSafeWorker();

+ ~ModelSafeWorker() override;

// Any time the Syncer performs model modifications (e.g employing a

// WriteTransaction), it should be done by this method to ensure it is done