Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: sync/internal_api/attachments/attachment_service_proxy_unittest.cc

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/attachments/attachment_service_proxy_unittest.cc
diff --git a/sync/internal_api/attachments/attachment_service_proxy_unittest.cc b/sync/internal_api/attachments/attachment_service_proxy_unittest.cc
index 68bd021c5cc860a09d147779e7dfd16afc4b297e..3d5cd552888829244456edc31fc61872728a3300 100644
--- a/sync/internal_api/attachments/attachment_service_proxy_unittest.cc
+++ b/sync/internal_api/attachments/attachment_service_proxy_unittest.cc
@@ -32,13 +32,13 @@ class StubAttachmentService : public AttachmentService,
DetachFromThread();
}
- virtual ~StubAttachmentService() {}
+ ~StubAttachmentService() override {}
- virtual AttachmentStore* GetStore() override { return NULL; }
+ AttachmentStore* GetStore() override { return NULL; }
- virtual void GetOrDownloadAttachments(const AttachmentIdList& attachment_ids,
- const GetOrDownloadCallback& callback)
- override {
+ void GetOrDownloadAttachments(
+ const AttachmentIdList& attachment_ids,
+ const GetOrDownloadCallback& callback) override {
CalledOnValidThread();
Increment();
scoped_ptr<AttachmentMap> attachments(new AttachmentMap());
@@ -49,16 +49,15 @@ class StubAttachmentService : public AttachmentService,
base::Passed(&attachments)));
}
- virtual void DropAttachments(const AttachmentIdList& attachment_ids,
- const DropCallback& callback) override {
+ void DropAttachments(const AttachmentIdList& attachment_ids,
+ const DropCallback& callback) override {
CalledOnValidThread();
Increment();
base::MessageLoop::current()->PostTask(
FROM_HERE, base::Bind(callback, AttachmentService::DROP_SUCCESS));
}
- virtual void UploadAttachments(
- const AttachmentIdSet& attachments_ids) override {
+ void UploadAttachments(const AttachmentIdSet& attachments_ids) override {
CalledOnValidThread();
Increment();
}

Powered by Google App Engine
This is Rietveld 408576698