Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: sync/internal_api/public/attachments/attachment_service_proxy.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/public/attachments/attachment_service_proxy.h
diff --git a/sync/internal_api/public/attachments/attachment_service_proxy.h b/sync/internal_api/public/attachments/attachment_service_proxy.h
index e41459df8828eb82fed04cffeec1e616b68355af..cab107ef690284ae5344e381ee991324d05e9d9f 100644
--- a/sync/internal_api/public/attachments/attachment_service_proxy.h
+++ b/sync/internal_api/public/attachments/attachment_service_proxy.h
@@ -48,19 +48,17 @@ class SYNC_EXPORT AttachmentServiceProxy : public AttachmentService {
const scoped_refptr<base::SequencedTaskRunner>& wrapped_task_runner,
const base::WeakPtr<syncer::AttachmentService>& wrapped);
- virtual ~AttachmentServiceProxy();
+ ~AttachmentServiceProxy() override;
// AttachmentService implementation.
//
// GetStore always returns NULL.
- virtual AttachmentStore* GetStore() override;
- virtual void GetOrDownloadAttachments(
- const AttachmentIdList& attachment_ids,
- const GetOrDownloadCallback& callback) override;
- virtual void DropAttachments(const AttachmentIdList& attachment_ids,
- const DropCallback& callback) override;
- virtual void UploadAttachments(
- const AttachmentIdSet& attachment_ids) override;
+ AttachmentStore* GetStore() override;
+ void GetOrDownloadAttachments(const AttachmentIdList& attachment_ids,
+ const GetOrDownloadCallback& callback) override;
+ void DropAttachments(const AttachmentIdList& attachment_ids,
+ const DropCallback& callback) override;
+ void UploadAttachments(const AttachmentIdSet& attachment_ids) override;
protected:
// Core does the work of proxying calls to AttachmentService methods from one
@@ -83,18 +81,17 @@ class SYNC_EXPORT AttachmentServiceProxy : public AttachmentService {
Core(const base::WeakPtr<syncer::AttachmentService>& wrapped);
// AttachmentService implementation.
- virtual AttachmentStore* GetStore() override;
- virtual void GetOrDownloadAttachments(
+ AttachmentStore* GetStore() override;
+ void GetOrDownloadAttachments(
const AttachmentIdList& attachment_ids,
const GetOrDownloadCallback& callback) override;
- virtual void DropAttachments(const AttachmentIdList& attachment_ids,
- const DropCallback& callback) override;
- virtual void UploadAttachments(
- const AttachmentIdSet& attachment_ids) override;
+ void DropAttachments(const AttachmentIdList& attachment_ids,
+ const DropCallback& callback) override;
+ void UploadAttachments(const AttachmentIdSet& attachment_ids) override;
protected:
friend class base::RefCountedThreadSafe<Core>;
- virtual ~Core();
+ ~Core() override;
private:
base::WeakPtr<AttachmentService> wrapped_;

Powered by Google App Engine
This is Rietveld 408576698