Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: sync/internal_api/js_mutation_event_observer.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/http_bridge_unittest.cc ('k') | sync/internal_api/js_sync_encryption_handler_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/js_mutation_event_observer.h
diff --git a/sync/internal_api/js_mutation_event_observer.h b/sync/internal_api/js_mutation_event_observer.h
index 5a007cbdc92dc1a77b56aa2fccb3c841bec85277..41bd9fab4f7fdc76b2983eeb279683209adda77c 100644
--- a/sync/internal_api/js_mutation_event_observer.h
+++ b/sync/internal_api/js_mutation_event_observer.h
@@ -34,7 +34,7 @@ class SYNC_EXPORT_PRIVATE JsMutationEventObserver
public:
JsMutationEventObserver();
- virtual ~JsMutationEventObserver();
+ ~JsMutationEventObserver() override;
base::WeakPtr<JsMutationEventObserver> AsWeakPtr();
@@ -43,14 +43,13 @@ class SYNC_EXPORT_PRIVATE JsMutationEventObserver
void SetJsEventHandler(const WeakHandle<JsEventHandler>& event_handler);
// SyncManager::ChangeObserver implementation.
- virtual void OnChangesApplied(
- ModelType model_type,
- int64 write_transaction_id,
- const ImmutableChangeRecordList& changes) override;
- virtual void OnChangesComplete(ModelType model_type) override;
+ void OnChangesApplied(ModelType model_type,
+ int64 write_transaction_id,
+ const ImmutableChangeRecordList& changes) override;
+ void OnChangesComplete(ModelType model_type) override;
// syncable::TransactionObserver implementation.
- virtual void OnTransactionWrite(
+ void OnTransactionWrite(
const syncable::ImmutableWriteTransactionInfo& write_transaction_info,
ModelTypeSet models_with_changes) override;
« no previous file with comments | « sync/internal_api/http_bridge_unittest.cc ('k') | sync/internal_api/js_sync_encryption_handler_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698