Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: sync/internal_api/sync_context_proxy_impl.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/sync_backup_manager.h ('k') | sync/internal_api/sync_encryption_handler_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/sync_context_proxy_impl.h
diff --git a/sync/internal_api/sync_context_proxy_impl.h b/sync/internal_api/sync_context_proxy_impl.h
index 09ec8b382af54eb3456a47dc543439533b7959b7..2bd6ba6ac370150290a09110e5627c7f08f68e0b 100644
--- a/sync/internal_api/sync_context_proxy_impl.h
+++ b/sync/internal_api/sync_context_proxy_impl.h
@@ -28,7 +28,7 @@ class SYNC_EXPORT_PRIVATE SyncContextProxyImpl : public SyncContextProxy {
SyncContextProxyImpl(
const scoped_refptr<base::SequencedTaskRunner>& sync_task_runner,
const base::WeakPtr<SyncContext>& sync_context);
- virtual ~SyncContextProxyImpl();
+ ~SyncContextProxyImpl() override;
// Attempts to connect a non-blocking type to the sync context.
//
@@ -37,16 +37,16 @@ class SYNC_EXPORT_PRIVATE SyncContextProxyImpl : public SyncContextProxy {
// unable to distinguish a slow success from failure.
//
// Must be called from the thread where the data type lives.
- virtual void ConnectTypeToSync(
+ void ConnectTypeToSync(
syncer::ModelType type,
const DataTypeState& data_type_state,
const UpdateResponseDataList& pending_updates,
const base::WeakPtr<ModelTypeSyncProxyImpl>& sync_proxy_impl) override;
// Disables syncing for the given type on the sync thread.
- virtual void Disconnect(syncer::ModelType type) override;
+ void Disconnect(syncer::ModelType type) override;
- virtual scoped_ptr<SyncContextProxy> Clone() const override;
+ scoped_ptr<SyncContextProxy> Clone() const override;
private:
// A SequencedTaskRunner representing the thread where the SyncContext lives.
« no previous file with comments | « sync/internal_api/sync_backup_manager.h ('k') | sync/internal_api/sync_encryption_handler_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698