Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: sync/engine/model_type_sync_worker_impl.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/get_updates_delegate.h ('k') | sync/engine/net/server_connection_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/model_type_sync_worker_impl.h
diff --git a/sync/engine/model_type_sync_worker_impl.h b/sync/engine/model_type_sync_worker_impl.h
index 1116adeca64f468c8b7a0322dad84902608466af..30015697f3fe714dda83825834f762e09a501ecf 100644
--- a/sync/engine/model_type_sync_worker_impl.h
+++ b/sync/engine/model_type_sync_worker_impl.h
@@ -59,7 +59,7 @@ class SYNC_EXPORT ModelTypeSyncWorkerImpl : public UpdateHandler,
scoped_ptr<Cryptographer> cryptographer,
NudgeHandler* nudge_handler,
scoped_ptr<ModelTypeSyncProxy> type_sync_proxy);
- virtual ~ModelTypeSyncWorkerImpl();
+ ~ModelTypeSyncWorkerImpl() override;
ModelType GetModelType() const;
@@ -67,25 +67,22 @@ class SYNC_EXPORT ModelTypeSyncWorkerImpl : public UpdateHandler,
void UpdateCryptographer(scoped_ptr<Cryptographer> cryptographer);
// UpdateHandler implementation.
- virtual void GetDownloadProgress(
+ void GetDownloadProgress(
sync_pb::DataTypeProgressMarker* progress_marker) const override;
- virtual void GetDataTypeContext(
- sync_pb::DataTypeContext* context) const override;
- virtual SyncerError ProcessGetUpdatesResponse(
+ void GetDataTypeContext(sync_pb::DataTypeContext* context) const override;
+ SyncerError ProcessGetUpdatesResponse(
const sync_pb::DataTypeProgressMarker& progress_marker,
const sync_pb::DataTypeContext& mutated_context,
const SyncEntityList& applicable_updates,
sessions::StatusController* status) override;
- virtual void ApplyUpdates(sessions::StatusController* status) override;
- virtual void PassiveApplyUpdates(sessions::StatusController* status) override;
+ void ApplyUpdates(sessions::StatusController* status) override;
+ void PassiveApplyUpdates(sessions::StatusController* status) override;
// ModelTypeSyncWorker implementation.
- virtual void EnqueueForCommit(
- const CommitRequestDataList& request_list) override;
+ void EnqueueForCommit(const CommitRequestDataList& request_list) override;
// CommitContributor implementation.
- virtual scoped_ptr<CommitContribution> GetContribution(
- size_t max_entries) override;
+ scoped_ptr<CommitContribution> GetContribution(size_t max_entries) override;
// Callback for when our contribution gets a response.
void OnCommitResponse(const CommitResponseDataList& response_list);
« no previous file with comments | « sync/engine/get_updates_delegate.h ('k') | sync/engine/net/server_connection_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698