Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: sync/engine/get_updates_delegate.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/directory_update_handler.h ('k') | sync/engine/model_type_sync_worker_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/get_updates_delegate.h
diff --git a/sync/engine/get_updates_delegate.h b/sync/engine/get_updates_delegate.h
index a4f999ab6ef9e05fe70ff14a0f127ef36938162c..32d74328a97c55d00b8aecc4a88c31b2d51c3102 100644
--- a/sync/engine/get_updates_delegate.h
+++ b/sync/engine/get_updates_delegate.h
@@ -43,21 +43,21 @@ class SYNC_EXPORT_PRIVATE GetUpdatesDelegate {
class SYNC_EXPORT_PRIVATE NormalGetUpdatesDelegate : public GetUpdatesDelegate {
public:
NormalGetUpdatesDelegate(const sessions::NudgeTracker& nudge_tracker);
- virtual ~NormalGetUpdatesDelegate();
+ ~NormalGetUpdatesDelegate() override;
// Uses the member NudgeTracker to populate some fields of this GU message.
- virtual void HelpPopulateGuMessage(
+ void HelpPopulateGuMessage(
sync_pb::GetUpdatesMessage* get_updates) const override;
// Applies pending updates on the appropriate data type threads.
- virtual void ApplyUpdates(
- ModelTypeSet gu_types,
- sessions::StatusController* status,
- UpdateHandlerMap* update_handler_map) const override;
+ void ApplyUpdates(ModelTypeSet gu_types,
+ sessions::StatusController* status,
+ UpdateHandlerMap* update_handler_map) const override;
- virtual scoped_ptr<ProtocolEvent> GetNetworkRequestEvent(
+ scoped_ptr<ProtocolEvent> GetNetworkRequestEvent(
base::Time timestamp,
const sync_pb::ClientToServerMessage& request) const override;
+
private:
DISALLOW_COPY_AND_ASSIGN(NormalGetUpdatesDelegate);
@@ -70,24 +70,24 @@ class SYNC_EXPORT_PRIVATE ConfigureGetUpdatesDelegate
public:
ConfigureGetUpdatesDelegate(
sync_pb::GetUpdatesCallerInfo::GetUpdatesSource source);
- virtual ~ConfigureGetUpdatesDelegate();
+ ~ConfigureGetUpdatesDelegate() override;
// Sets the 'source' and 'origin' fields for this request.
- virtual void HelpPopulateGuMessage(
+ void HelpPopulateGuMessage(
sync_pb::GetUpdatesMessage* get_updates) const override;
// Applies updates passively (ie. on the sync thread).
//
// This is safe only if the ChangeProcessor is not listening to changes at
// this time.
- virtual void ApplyUpdates(
- ModelTypeSet gu_types,
- sessions::StatusController* status,
- UpdateHandlerMap* update_handler_map) const override;
+ void ApplyUpdates(ModelTypeSet gu_types,
+ sessions::StatusController* status,
+ UpdateHandlerMap* update_handler_map) const override;
- virtual scoped_ptr<ProtocolEvent> GetNetworkRequestEvent(
+ scoped_ptr<ProtocolEvent> GetNetworkRequestEvent(
base::Time timestamp,
const sync_pb::ClientToServerMessage& request) const override;
+
private:
DISALLOW_COPY_AND_ASSIGN(ConfigureGetUpdatesDelegate);
@@ -101,21 +101,21 @@ class SYNC_EXPORT_PRIVATE ConfigureGetUpdatesDelegate
class SYNC_EXPORT_PRIVATE PollGetUpdatesDelegate : public GetUpdatesDelegate {
public:
PollGetUpdatesDelegate();
- virtual ~PollGetUpdatesDelegate();
+ ~PollGetUpdatesDelegate() override;
// Sets the 'source' and 'origin' to indicate this is a poll request.
- virtual void HelpPopulateGuMessage(
+ void HelpPopulateGuMessage(
sync_pb::GetUpdatesMessage* get_updates) const override;
// Applies updates on the appropriate data type thread.
- virtual void ApplyUpdates(
- ModelTypeSet gu_types,
- sessions::StatusController* status,
- UpdateHandlerMap* update_handler_map) const override;
+ void ApplyUpdates(ModelTypeSet gu_types,
+ sessions::StatusController* status,
+ UpdateHandlerMap* update_handler_map) const override;
- virtual scoped_ptr<ProtocolEvent> GetNetworkRequestEvent(
+ scoped_ptr<ProtocolEvent> GetNetworkRequestEvent(
base::Time timestamp,
const sync_pb::ClientToServerMessage& request) const override;
+
private:
DISALLOW_COPY_AND_ASSIGN(PollGetUpdatesDelegate);
};
« no previous file with comments | « sync/engine/directory_update_handler.h ('k') | sync/engine/model_type_sync_worker_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698