sync/internal_api/public/write_transaction.h - Issue 642023004: Standardize usage of virtual/override/final in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/write_transaction.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/internal_api/public/write_transaction.h

diff --git a/sync/internal_api/public/write_transaction.h b/sync/internal_api/public/write_transaction.h

index e1000419b9fd5c42bce9a8e8d4f243133744cbe6..8d8d101b67baf3391c18ed038acbb929d74f97a9 100644

--- a/sync/internal_api/public/write_transaction.h

+++ b/sync/internal_api/public/write_transaction.h

@@ -38,10 +38,10 @@ class SYNC_EXPORT WriteTransaction : public BaseTransaction {

// types that support embassy data.

WriteTransaction(const tracked_objects::Location& from_here,

UserShare* share, int64* transaction_version);

- virtual ~WriteTransaction();

+ ~WriteTransaction() override;

// Provide access to the syncable transaction from the API WriteNode.

- virtual syncable::BaseTransaction* GetWrappedTrans() const override;

+ syncable::BaseTransaction* GetWrappedTrans() const override;

syncable::WriteTransaction* GetWrappedWriteTrans() { return transaction_; }

// Set's a |type|'s local context. |refresh_status| controls whether

« no previous file with comments | « sync/internal_api/public/write_node.h ('k') | sync/internal_api/sync_backup_manager.h » ('j') | no next file with comments »