sync/engine/syncer_proto_util_unittest.cc - Issue 642023004: Standardize usage of virtual/override/final in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/engine/syncer_proto_util_unittest.cc

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/engine/syncer_proto_util_unittest.cc

diff --git a/sync/engine/syncer_proto_util_unittest.cc b/sync/engine/syncer_proto_util_unittest.cc

index 8e731937e33f2319eab938fdf6921ee278c8b7fd..81b25662894bdbb2ac7422e47c570cada4de8a8f 100644

--- a/sync/engine/syncer_proto_util_unittest.cc

+++ b/sync/engine/syncer_proto_util_unittest.cc

@@ -257,10 +257,9 @@ class DummyConnectionManager : public ServerConnectionManager {

send_error_(false),

access_denied_(false) {}

- virtual ~DummyConnectionManager() {}

- virtual bool PostBufferWithCachedAuth(

- PostBufferParams* params,

- ScopedServerStatusWatcher* watcher) override {

+ ~DummyConnectionManager() override {}

+ bool PostBufferWithCachedAuth(PostBufferParams* params,

+ ScopedServerStatusWatcher* watcher) override {

if (send_error_) {

return false;

}

« no previous file with comments | « sync/engine/sync_scheduler_impl.h ('k') | sync/engine/syncer_unittest.cc » ('j') | no next file with comments »