sync/internal_api/public/attachments/fake_attachment_uploader.h - Issue 642023004: Standardize usage of virtual/override/final in sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/attachments/fake_attachment_uploader.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/public/attachments/fake_attachment_downloader.h ('k') | sync/internal_api/public/attachments/in_memory_attachment_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/attachments/fake_attachment_uploader.h

diff --git a/sync/internal_api/public/attachments/fake_attachment_uploader.h b/sync/internal_api/public/attachments/fake_attachment_uploader.h

index 16d3a51cc60b5a64982c3605aecf7bb8982ce6a9..74f2a1ff11cb47fa347350e1e56ddae67ca6f642 100644

--- a/sync/internal_api/public/attachments/fake_attachment_uploader.h

+++ b/sync/internal_api/public/attachments/fake_attachment_uploader.h

@@ -15,11 +15,11 @@ class SYNC_EXPORT FakeAttachmentUploader : public AttachmentUploader,

public base::NonThreadSafe {

public:

FakeAttachmentUploader();

- virtual ~FakeAttachmentUploader();

+ ~FakeAttachmentUploader() override;

// AttachmentUploader implementation.

- virtual void UploadAttachment(const Attachment& attachment,

- const UploadCallback& callback) override;

+ void UploadAttachment(const Attachment& attachment,

+ const UploadCallback& callback) override;

private:

DISALLOW_COPY_AND_ASSIGN(FakeAttachmentUploader);