Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Side by Side Diff: sync/engine/directory_update_handler.h

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sync/engine/directory_commit_contributor.h ('k') | sync/engine/get_updates_delegate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SYNC_ENGINE_DIRECTORY_UPDATE_HANDLER_H_ 5 #ifndef SYNC_ENGINE_DIRECTORY_UPDATE_HANDLER_H_
6 #define SYNC_ENGINE_DIRECTORY_UPDATE_HANDLER_H_ 6 #define SYNC_ENGINE_DIRECTORY_UPDATE_HANDLER_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 29 matching lines...) Expand all
40 // 40 //
41 // Each instance of this class represents a particular type in the 41 // Each instance of this class represents a particular type in the
42 // syncable::Directory. It can store and retreive that type's progress markers. 42 // syncable::Directory. It can store and retreive that type's progress markers.
43 // It can also process a set of received SyncEntities and store their data. 43 // It can also process a set of received SyncEntities and store their data.
44 class SYNC_EXPORT_PRIVATE DirectoryUpdateHandler : public UpdateHandler { 44 class SYNC_EXPORT_PRIVATE DirectoryUpdateHandler : public UpdateHandler {
45 public: 45 public:
46 DirectoryUpdateHandler(syncable::Directory* dir, 46 DirectoryUpdateHandler(syncable::Directory* dir,
47 ModelType type, 47 ModelType type,
48 scoped_refptr<ModelSafeWorker> worker, 48 scoped_refptr<ModelSafeWorker> worker,
49 DirectoryTypeDebugInfoEmitter* debug_info_emitter); 49 DirectoryTypeDebugInfoEmitter* debug_info_emitter);
50 virtual ~DirectoryUpdateHandler(); 50 ~DirectoryUpdateHandler() override;
51 51
52 // UpdateHandler implementation. 52 // UpdateHandler implementation.
53 virtual void GetDownloadProgress( 53 void GetDownloadProgress(
54 sync_pb::DataTypeProgressMarker* progress_marker) const override; 54 sync_pb::DataTypeProgressMarker* progress_marker) const override;
55 virtual void GetDataTypeContext(sync_pb::DataTypeContext* context) const 55 void GetDataTypeContext(sync_pb::DataTypeContext* context) const override;
56 override; 56 SyncerError ProcessGetUpdatesResponse(
57 virtual SyncerError ProcessGetUpdatesResponse(
58 const sync_pb::DataTypeProgressMarker& progress_marker, 57 const sync_pb::DataTypeProgressMarker& progress_marker,
59 const sync_pb::DataTypeContext& mutated_context, 58 const sync_pb::DataTypeContext& mutated_context,
60 const SyncEntityList& applicable_updates, 59 const SyncEntityList& applicable_updates,
61 sessions::StatusController* status) override; 60 sessions::StatusController* status) override;
62 virtual void ApplyUpdates(sessions::StatusController* status) override; 61 void ApplyUpdates(sessions::StatusController* status) override;
63 virtual void PassiveApplyUpdates(sessions::StatusController* status) override; 62 void PassiveApplyUpdates(sessions::StatusController* status) override;
64 63
65 private: 64 private:
66 friend class DirectoryUpdateHandlerApplyUpdateTest; 65 friend class DirectoryUpdateHandlerApplyUpdateTest;
67 friend class DirectoryUpdateHandlerProcessUpdateTest; 66 friend class DirectoryUpdateHandlerProcessUpdateTest;
68 67
69 // Sometimes there is nothing to do, so we can return without doing anything. 68 // Sometimes there is nothing to do, so we can return without doing anything.
70 bool IsApplyUpdatesRequired(); 69 bool IsApplyUpdatesRequired();
71 70
72 // Processes the given SyncEntities and stores their data in the directory. 71 // Processes the given SyncEntities and stores their data in the directory.
73 // Their types must match this update handler's type. 72 // Their types must match this update handler's type.
(...skipping 24 matching lines...) Expand all
98 DirectoryTypeDebugInfoEmitter* debug_info_emitter_; 97 DirectoryTypeDebugInfoEmitter* debug_info_emitter_;
99 98
100 scoped_ptr<sync_pb::GarbageCollectionDirective> cached_gc_directive_; 99 scoped_ptr<sync_pb::GarbageCollectionDirective> cached_gc_directive_;
101 100
102 DISALLOW_COPY_AND_ASSIGN(DirectoryUpdateHandler); 101 DISALLOW_COPY_AND_ASSIGN(DirectoryUpdateHandler);
103 }; 102 };
104 103
105 } // namespace syncer 104 } // namespace syncer
106 105
107 #endif // SYNC_ENGINE_DIRECTORY_UPDATE_HANDLER_H_ 106 #endif // SYNC_ENGINE_DIRECTORY_UPDATE_HANDLER_H_
OLDNEW
« no previous file with comments | « sync/engine/directory_commit_contributor.h ('k') | sync/engine/get_updates_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698